Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add TypeWatch v2.2.2 with git autoupdate config #8022

Merged
merged 1 commit into from
May 24, 2016

Conversation

pvnr0082t
Copy link
Contributor

PR for #7848
@kennynaoh Please help me review this pull request, thank you.

Checklist for Pull request or lib adding request issue follows the conventions.

Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.

Profile of the lib

  • Git repository (required): https://github.com/dennyferra/TypeWatch
  • Official website (optional, not the repository):
  • NPM package url (optional):
  • GitHub / Bitbucket popularity (required):
    • Count of stars: 152
    • Count of watchers: 11
    • Count of forks: 43
  • NPM download stats (optional):
    • Downloads in the last day:
    • Downloads in the last week:
    • Downloads in the last month:

Essential checklist

  • I'm the author of this library
    • I would like to add link to the page of this library on CDNJS on website / readme
  • This lib was not found on cdnjs repo
  • No already exist / duplicated issue and PR
  • The lib has notable popularity
    • More than 100 [Stars / Watchers / Forks] on [GitHub / Bitbucket]
    • More than 500 downloads stats per month on npm registry
  • Project has public repository on famous online hosting platform (or been hosted on npm)

Auto-update checklist

  • Has valid tags for each versions (for git auto-update)
  • Auto-update setup
  • Auto-update target/source is valid.
  • Auto-update filemap is correct.

Git commit checklist

  • The first line of commit message is less then 50 chars, be clean and clear, easy to understand.
  • The parent of the commit(s) in the PR is not old than 3 days.
  • Pull request is sending from a non-master branch with meaningful name.
  • Separate unrelated changes into different commits.
  • Use rebase to squash/fixup dummy/unnecessary commits into only one commit.
  • Close corresponding issue in commit message
  • Mention related issue(s), people in commit message, comment.

close #7848, cc @dennyferra

@kennynaoh
Copy link
Contributor

@pvnr0082t
I found that the jquery.typewatch.js version in master branch is 3.
But the version in latest release is still 2.2.2.
Please confirm that.
Thanks!

@kennynaoh kennynaoh assigned pvnr0082t and unassigned kennynaoh May 23, 2016
@pvnr0082t
Copy link
Contributor Author

@kennynaoh I think you don't need to care about master branch. Maybe the author is still developing and don't want to release now.

@pvnr0082t pvnr0082t assigned kennynaoh and unassigned pvnr0082t May 23, 2016
@kennynaoh
Copy link
Contributor

@PeterDaveHello
I think this PR is correct.
Please help me review it again.
Thanks.

@PeterDaveHello
Copy link
Contributor

We need to confirm its license.

@pvnr0082t
Copy link
Contributor Author

@kennynaoh I confirmed license in Check license and it's GPLv3. Please help me review again, thank you.

@pvnr0082t pvnr0082t assigned kennynaoh and unassigned pvnr0082t May 23, 2016
@PeterDaveHello
Copy link
Contributor

@pvnr0082t why not send a PR to contribute to upstream? The package.json should be updated.

@pvnr0082t
Copy link
Contributor Author

@PeterDaveHello I will send it.

@PeterDaveHello
Copy link
Contributor

Something wrong, can you update your commit and PR to trigger a new build test?

@pvnr0082t
Copy link
Contributor Author

@kennynaoh Please help me review again, thank you.

@PeterDaveHello PeterDaveHello merged commit bc5d7bb into cdnjs:master May 24, 2016
@pvnr0082t pvnr0082t deleted the TypeWatch branch July 18, 2016 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Add typewatch
3 participants