Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rantjs w/ git autoupdate #8343

Merged
merged 2 commits into from
Jul 29, 2016
Merged

add rantjs w/ git autoupdate #8343

merged 2 commits into from
Jul 29, 2016

Conversation

pvnr0082t
Copy link
Contributor

@pvnr0082t pvnr0082t commented Jun 24, 2016

PR for #7698
@x09326 Please help me review this pull request, thank you.

Checklist for Pull request or lib adding request issue follows the conventions.

Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.

Profile of the lib

Essential checklist

  • I'm the author of this library
    • I would like to add link to the page of this library on CDNJS on website / readme
  • This lib was not found on cdnjs repo
  • No already exist / duplicated issue and PR
  • The lib has notable popularity
    • More than 100 [Stars / Watchers / Forks] on [GitHub / Bitbucket]
    • More than 500 downloads stats per month on npm registry
  • Project has public repository on famous online hosting platform (or been hosted on npm)

Auto-update checklist

  • Has valid tags for each versions (for git auto-update)
  • Auto-update setup
  • Auto-update target/source is valid.
  • Auto-update filemap is correct.

Git commit checklist

  • The first line of commit message is less then 50 chars, be clean and clear, easy to understand.
  • The parent of the commit(s) in the PR is not old than 3 days.
  • Pull request is sending from a non-master branch with meaningful name.
  • Separate unrelated changes into different commits.
  • Use rebase to squash/fixup dummy/unnecessary commits into only one commit.
  • Close corresponding issue in commit message
  • Mention related issue(s), people in commit message, comment.

close #7698, cc @svenanders

@x09326
Copy link
Contributor

x09326 commented Jun 26, 2016

The first line of the commit is more than 50 chars.

@pvnr0082t
Copy link
Contributor Author

@x09326 I have updated commit message. Please help me review again, thank you.

@pvnr0082t pvnr0082t assigned x09326 and unassigned pvnr0082t Jun 26, 2016
@PeterDaveHello
Copy link
Contributor

Is the index*.js the same as rant*.js under https://github.com/svenanders/Rantjs/tree/master/dist ? I prefer to use dist folder and the name with meaning.

@pvnr0082t
Copy link
Contributor Author

@PeterDaveHello index*.js and rant*.js are totally the same. so how could I do? Grab files from Github? But there is no any tagged release on GitHub. Should I open an issue to ask for adding git tag?

@pvnr0082t pvnr0082t assigned pvnr0082t and unassigned x09326 Jun 26, 2016
@PeterDaveHello
Copy link
Contributor

@pvnr0082t Yeah we can discuss with the author.

@pvnr0082t pvnr0082t changed the title add rantjs@1.0.5 w/ npm autoupdate add rantjs@1.0.6 w/ npm autoupdate Jun 28, 2016
@pvnr0082t pvnr0082t changed the title add rantjs@1.0.6 w/ npm autoupdate add rantjs@1.0.6 w/ git autoupdate Jun 28, 2016
@pvnr0082t
Copy link
Contributor Author

@x09326 I have grabbed files from GitHub and replace npm auto-update with git auto-update. The latest version is v1.0.6. Please help me review again, thank you.

@pvnr0082t pvnr0082t assigned x09326 and unassigned pvnr0082t Jun 28, 2016
@x09326 x09326 assigned PeterDaveHello and unassigned x09326 Jun 29, 2016
"text",
"sentences"
],
"homepage": "http://www.robbestad.com/blog/procedurally-generated-text-with-rantjs",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use https instead of http

@x09326 x09326 assigned pvnr0082t and unassigned PeterDaveHello Jun 29, 2016
@pvnr0082t
Copy link
Contributor Author

@x09326 I have updated homepage field. Please help me review again, thank you.

@pvnr0082t pvnr0082t assigned x09326 and unassigned pvnr0082t Jun 29, 2016
@PeterDaveHello
Copy link
Contributor

@pvnr0082t since there are much more versions on npm, would you please manually grab the old versions from npm with filename change? Thanks.

@PeterDaveHello PeterDaveHello assigned pvnr0082t and unassigned x09326 Jun 29, 2016
@pvnr0082t pvnr0082t changed the title add rantjs@1.0.6 w/ git autoupdate add rantjs w/ git autoupdate Jul 25, 2016
@pvnr0082t
Copy link
Contributor Author

@x09326 I have add old versions from npm with filename change. Please help me review again, thank you.

@PeterDaveHello
Copy link
Contributor

@pvnr0082t please do not generate the map file since v1.0.4/1.0.5 were officially minified, we try to keep the consistency, the map file could be added in new versions only.

@pvnr0082t
Copy link
Contributor Author

@x09326 I have minified without map file. Please help me review again, thank you.

@pvnr0082t pvnr0082t assigned x09326 and unassigned pvnr0082t Jul 26, 2016
@PeterDaveHello
Copy link
Contributor

Looks great, one last thing @pvnr0082t, to keep the consistency, let's add symbolic links for those versions do not have rant.min.js, so that the users can always use the name rant.min.js between different versions.

@pvnr0082t pvnr0082t assigned pvnr0082t and unassigned x09326 Jul 29, 2016
@pvnr0082t
Copy link
Contributor Author

@PeterDaveHello copy rant.js to a new file named rant.min.js and link rant.js to rant.min.js?

@PeterDaveHello
Copy link
Contributor

@pvnr0082t or just add a symbolic link rant.min.js -> rant.js, thanks.

Manually add the other versions with filename change from npm.
@pvnr0082t
Copy link
Contributor Author

@x09326 I have added symbolic link for those versions do not have rant.min.js. Please help me review again, thank you.

@pvnr0082t pvnr0082t assigned x09326 and unassigned pvnr0082t Jul 29, 2016
@PeterDaveHello PeterDaveHello merged commit f2fbaa5 into cdnjs:master Jul 29, 2016
@pvnr0082t pvnr0082t deleted the Rantjs branch August 4, 2016 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] rantjs
3 participants