-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add rantjs w/ git autoupdate #8343
Conversation
The first line of the commit is more than 50 chars. |
@x09326 I have updated commit message. Please help me review again, thank you. |
Is the |
@PeterDaveHello |
@pvnr0082t Yeah we can discuss with the author. |
@x09326 I have grabbed files from GitHub and replace npm auto-update with git auto-update. The latest version is v1.0.6. Please help me review again, thank you. |
"text", | ||
"sentences" | ||
], | ||
"homepage": "http://www.robbestad.com/blog/procedurally-generated-text-with-rantjs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use https instead of http
@x09326 I have updated homepage field. Please help me review again, thank you. |
@pvnr0082t since there are much more versions on npm, would you please manually grab the old versions from npm with filename change? Thanks. |
@x09326 I have add old versions from npm with filename change. Please help me review again, thank you. |
@pvnr0082t please do not generate the map file since v1.0.4/1.0.5 were officially minified, we try to keep the consistency, the map file could be added in new versions only. |
@x09326 I have minified without map file. Please help me review again, thank you. |
Looks great, one last thing @pvnr0082t, to keep the consistency, let's add symbolic links for those versions do not have |
@PeterDaveHello copy |
@pvnr0082t or just add a symbolic link rant.min.js -> rant.js, thanks. |
close cdnjs#7698, cc @svenanders
Manually add the other versions with filename change from npm.
@x09326 I have added symbolic link for those versions do not have |
PR for #7698
@x09326 Please help me review this pull request, thank you.
Checklist for Pull request or lib adding request issue follows the conventions.
Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.
Profile of the lib
Essential checklist
Auto-update checklist
Git commit checklist
close #7698, cc @svenanders