New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dom-to-image w/ npm auto-update #8701
Conversation
@PeterDaveHello I think this PR is ok. Please review it again, thank you. |
Some versions have different naming for the src and dist file, would you please make them the same? Maybe could ask the author for suggestions, thanks. |
812f86d
to
bf9e33b
Compare
The author said |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub show that this branch is out-of-date with the base branch. Please rebased on the latest master branch, thanks. @kennynaoh
LGTM |
@kennynaoh |
Manually add the other versions from git repo because npm auto-update can't get some of the old versions, cc cdnjs#8589
bf9e33b
to
fdabca3
Compare
@pvnr0082t , @x09326 |
LGTM |
PR for #8589
@x09326 please help me review this pull request, thank you.
Checklist for Pull request or lib adding request issue follows the conventions.
Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.
Profile of the lib
Essential checklist
Auto-update checklist
Git commit checklist