Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add appbase-js v0.10.8 w/ npm auto-update #8914

Merged
merged 1 commit into from
Sep 10, 2016

Conversation

maruilian11
Copy link
Contributor

@maruilian11 maruilian11 commented Sep 5, 2016

@Amomo could u help me check this PR for #8687 ? thank you!

git repo url: https://github.com/appbaseio/appbase-js
Watch 6
Star 5
Fork 6

npm package url: https://www.npmjs.com/package/appbase-js
29 downloads in the last day
72 downloads in the last week
282 downloads in the last month

Checklist for Pull request or lib adding request issue follows the conventions.

Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.

Essential checklist

  • I'm the author of this library
    • I would like to add link to the page of this library on CDNJS on website / readme
  • This lib was not found on cdnjs repo
  • No already exist / duplicated issue and PR
  • The lib has notable popularity [Request] Add appbase-js #8687 (comment)
    • More than 100 [Stars / Watchers / Forks] on [GitHub / Bitbucket]
    • More than 500 downloads stats per month on npm registry
  • Project has public repository on famous online hosting platform (or been hosted on npm)

Auto-update checklist

  • Has valid tags for each versions (for git auto-update)
  • Auto-update setup
  • Auto-update target/source is valid.
  • Auto-update filemap is correct.

Git commit checklist

  • The first line of commit message is less then 50 chars, be clean and clear, easy to understand.
  • The parent of the commit(s) in the PR is not old than 3 days.
  • Pull request is sending from a non-master branch with meaningful name.
  • Separate unrelated changes into different commits.
  • Use rebase to squash/fixup dummy/unnecessary commits into only one commit.
  • Close corresponding issue in commit message
  • Mention related issue(s), people in commit message, comment.

@PeterDaveHello
Copy link
Contributor

Different comment with the commit?

@maruilian11
Copy link
Contributor Author

maruilian11 commented Sep 6, 2016

when I checked the PR not sent, I put the "Enter" accidentally.
and I found out its popularity was not enough, so I closed the PR without revising it.

@PeterDaveHello
Copy link
Contributor

I think I replied on that issue and said we could add it earlier, let's finish this ASAP.

@PeterDaveHello PeterDaveHello reopened this Sep 6, 2016
@maruilian11 maruilian11 changed the title add appbase-js v0.10.8 w/ git auto-update add appbase-js v0.10.8 w/ npm auto-update Sep 7, 2016
@maruilian11
Copy link
Contributor Author

@Amomo @Piicksarn I add this lib with npm auto-update, could you help me check this PR? thank you!

@PeterDaveHello
Copy link
Contributor

There is a 1.0.0 version in npm package, please confirm that if it's okay, or maybe we need to add it to .gitignore

@maruilian11
Copy link
Contributor Author

@Amomo @Piicksarn I have add v1.0.0 to gitignore, could you help me check this PR? thanks.
appbaseio/appbase-js#16 (comment)

@PeterDaveHello PeterDaveHello merged commit 61342fd into cdnjs:master Sep 10, 2016
@PeterDaveHello
Copy link
Contributor

You should mention the reason you add the path the .gitignore, and it's not gitinore.

@maruilian11
Copy link
Contributor Author

got it.

@maruilian11 maruilian11 deleted the appbase-js branch September 10, 2016 14:21
@maruilian11
Copy link
Contributor Author

@Amomo @Piicksarn
I add v1.0.0 to .gitignore because there is v1.0.0 in npm package, but it's not on git repo.
and the latest version is 0.10.8, it's wired v1.0.0 is already on npm, so I opened an issue to confirm with the author if we need to host v1.0.0, and the author said we don't.

@Piicksarn
Copy link
Contributor

@PeterDaveHello, should we remove the commend in .gitinore manually when the version 1.0.0 released?

@PeterDaveHello
Copy link
Contributor

@Piicksarn the author will send a PR for it, you can remove it then, or just leave it alone, both fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants