-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add appbase-js v0.10.8 w/ npm auto-update #8914
Conversation
Different comment with the commit? |
when I checked the PR not sent, I put the "Enter" accidentally. |
I think I replied on that issue and said we could add it earlier, let's finish this ASAP. |
6acb6c1
to
cc332dd
Compare
@Amomo @Piicksarn I add this lib with npm auto-update, could you help me check this PR? thank you! |
There is a |
cc332dd
to
1952c13
Compare
1952c13
to
8b29104
Compare
@Amomo @Piicksarn I have add v1.0.0 to |
You should mention the reason you add the path the |
got it. |
@Amomo @Piicksarn |
@PeterDaveHello, should we remove the commend in .gitinore manually when the version 1.0.0 released? |
@Piicksarn the author will send a PR for it, you can remove it then, or just leave it alone, both fine. |
@Amomo could u help me check this PR for #8687 ? thank you!
git repo url: https://github.com/appbaseio/appbase-js
Watch 6
Star 5
Fork 6
npm package url: https://www.npmjs.com/package/appbase-js
29 downloads in the last day
72 downloads in the last week
282 downloads in the last month
Checklist for Pull request or lib adding request issue follows the conventions.
Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.
Essential checklist
Auto-update checklist
Git commit checklist