New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new] Add choices.js v2.0.2 #8927
Conversation
@cdnjs/intern2 please help review this PR, thanks. |
ajax/libs/choices.js/package.json
Outdated
"name": "choices.js", | ||
"version": "2.0.2", | ||
"description": "A vanilla JS customisable text input/select box plugin", | ||
"main": "./assets/scripts/dist/choices.min.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iv-craig Let's remove some fields we don't need. Like main
, scripts
, bugs
, devDependencies
.
Hello @iv-craig , |
Hello @iv-craig {
"basePath": "assets/scripts/dist",
"files": [
"**/*"
]
},
{
"basePath": "assets/styles",
"files": [
"css/+(base|choice)*"
]
},
{
"basePath": "assets/icons",
"files": [
"*.svg"
]
} Thanks! |
Hi @kennynaoh |
@iv-craig Did you run under the root of cdnjs by ./tools/fixFormat.js? |
@PeterDaveHello I had put the fixFormat functionality into a gulpfile and ran that locally to avoid cloning the whole cdnjs repo, but even after cloning the repo and running it from the cdnjs root it doesn't appear to have made any changes. |
@iv-craig any error there? Can you try to run it via command line instead of via gulp? Thanks. |
@kennynaoh the filemap looks a little bit complex, could it be easier and cleaner? |
It can pass the test after I ran |
@PeterDaveHello @pvnr0082t Committing from the command-line instead of the browser seems to have worked -- doing a sparse checkout also helped, I was getting errors during an earlier clone attempt. Thanks! |
@iv-craig Congratulations! |
@cdnjs/intern2 any updates here? |
@iv-craig |
@kennynaoh the filemap looks a little bit complex, could it be easier and cleaner? |
@PeterDaveHello {
"basePath": "assets",
"files": [
"scripts/dist/**/*",
"styles/css/+(base|choice)*",
"icons/*.svg"
]
} |
We may need to slow down this PR, the structure looks not so good and common, can somebody help discuss with the author about the possibility to distribute all the distribution purpose files under a single |
Any updates here? Thanks! |
Any updates here? Thanks! |
No updates, sorry. Been under a time crunch for...a while, and it's not letting up any time soon. Feel free to close this if you'd like. |
@iv-craig no worries, I'll take care of it. |
Any updates here? Thanks! |
close cdnjs#8927, close cdnjs#11540, cc cdnjs#11170, cc @jshjohnson
Manually add v2.7.3, v2.7.4, v2.7.5, v2.8.1, v2.8.2 from GitHub due to their unavailability on npm. cc cdnjs#8927, cdnjs#11170, cdnjs#11540
First time I'm adding a package, so I'm not sure if I've got the auto-update/git commit checklists right. Please let me know if there's anything I need to update.
Checklist for Pull request or lib adding request issue follows the conventions.
Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.
Profile of the lib
Essential checklist
Auto-update checklist
Git commit checklist