add origamijs@0.5.1 and update .gitignore #9108

kennynaoh · 2016-09-27T07:07:45Z

PR for #9060
@x09326 please help me review this pull request, thank you.
add .gitignore to ignore v0.0.2 because v0.0.2 doesn't exist on npm and has no origami.js on git repo, author said he want to forget v0.0.2
raphamorim/origami.js#39 (comment)
Checklist for Pull request or lib adding request issue follows the conventions.

Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.

Profile of the lib

Git repository (required): https://github.com/raphamorim/origami.js
Official website (optional, not the repository): http://origamijs.com
NPM package url (optional): https://www.npmjs.com/package/origamijs
GitHub / Bitbucket popularity (required):
- Count of stars: 568
- Count of watchers: 25
- Count of forks: 34
NPM download stats (optional):
- Downloads in the last day: 3
- Downloads in the last week: 235
- Downloads in the last month: 365

Essential checklist

I'm the author of this library
- I would like to add link to the page of this library on CDNJS on website / readme
This lib was not found on cdnjs repo
No already exist / duplicated issue and PR
The lib has notable popularity
- More than 100 [Stars / Watchers / Forks] on [GitHub / Bitbucket]
- More than 500 downloads stats per month on npm registry
Project has public repository on famous online hosting platform (or been hosted on npm)

Auto-update checklist

Has valid tags for each versions (for git auto-update)
Auto-update setup
Auto-update target/source is valid.
Auto-update filemap is correct.

Git commit checklist

The first line of commit message is less then 50 chars, be clean and clear, easy to understand.
The parent of the commit(s) in the PR is not old than 3 days.
Pull request is sending from a non-master branch with meaningful name.
Separate unrelated changes into different commits.
Use rebase to squash/fixup dummy/unnecessary commits into only one commit.
Close corresponding issue in commit message
Mention related issue(s), people in commit message, comment.

npm auto-update config added and add .gitignore to ignore v0.0.2 because
author don't care, close #9060, cc @raphamorim

x09326 · 2016-09-29T05:25:30Z

ajax/libs/origamijs/0.5.1/origami.js

@@ -0,0 +1,1153 @@
+/*!
+ * Origami.js 0.5.0


@kennynaoh
Here is 0.5.0.
Would you confirm this?

PeterDaveHello · 2016-09-27T08:51:46Z

.gitignore

@@ -158,6 +158,8 @@ ajax/libs/Hyphenator/HyphenatorBeta12/
 ajax/libs/Hyphenator/ersion_*
 ajax/libs/gemma/0.1.0/
 ajax/libs/gemma/0.4.0/
+ajax/libs/origamijs/0.0.2/
+


This empty line should be removed, we already have that.

kennynaoh · 2016-10-04T03:35:10Z

@x09326
That is just a typo (raphamorim/origami.js#39)
And removed the blank line.
Please help me review it again.
Thanks!

raphamorim · 2016-10-04T03:37:52Z

Make sense 👍

kennynaoh · 2016-10-04T03:47:19Z

x09326 · 2016-10-04T12:26:01Z

ajax/libs/origamijs/0.5.1/origami.js

+ * https://origamijs.com/
+ *
+ * Copyright Raphael Amorim 2016
+ * Released under the GPL-4.0 license


@kennynaoh
Please confirm the license.
It is different from the license in package.json.

raphamorim · 2016-10-04T14:54:06Z

Ref: raphamorim/origami.js#42

kennynaoh · 2016-10-05T03:10:59Z

Thanks @raphamorim ✨

kennynaoh · 2016-10-05T03:27:40Z

@x09326
Please help me review it again.
Thanks!

x09326 · 2016-10-05T06:16:16Z

LGTM
ping @PeterDaveHello

PeterDaveHello · 2016-10-05T06:19:50Z

"npm auto-update config added and add .gitignore to ignore v0.0.2 because author don't care"

I didn't get what do you mean, the author doesn't care for what? @kennynaoh

kennynaoh · 2016-10-05T06:43:09Z

@PeterDaveHello
The author said let's forget v0.0.2

PeterDaveHello · 2016-10-05T07:44:48Z

Where did the author say that? Give us the reference in PR comment.
Clarify your comment and commit message.

@raphamorim

npm auto-update config added and update .gitignore to ignore v0.0.2 because v0.0.2 doesn't exist on npm and has no origami.js on git repo, author said he want to forget v0.0.2, close cdnjs#9060, cc @raphamorim

kennynaoh · 2016-10-05T09:16:44Z

@x09326
I have clarified the comment in commit message and add ref in PR comment
Please help me review it again.
Thanks!

x09326 · 2016-10-05T09:19:11Z

LGTM
ping @PeterDaveHello

PeterDaveHello added the in progress label Sep 27, 2016

kennynaoh assigned x09326 Sep 27, 2016

PeterDaveHello changed the title ~~add origamijs@0.5.1 and .gitignore~~ add origamijs@0.5.1 and update .gitignore Sep 27, 2016

x09326 reviewed Sep 29, 2016

View reviewed changes

ajax/libs/origamijs/0.5.1/origami.js

@@ -0,0 +1,1153 @@

/*!

* Origami.js 0.5.0

Copy link

Contributor

x09326 Sep 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kennynaoh
Here is 0.5.0.
Would you confirm this?

PeterDaveHello suggested changes Sep 29, 2016

View reviewed changes

kennynaoh force-pushed the origamijs branch from 833501a to 9db3297 Compare October 4, 2016 03:07

x09326 reviewed Oct 4, 2016

View reviewed changes

kennynaoh force-pushed the origamijs branch from 9db3297 to e4081f7 Compare October 5, 2016 03:02

PeterDaveHello assigned pvnr0082t Oct 5, 2016

PeterDaveHello assigned kennynaoh and unassigned x09326 and pvnr0082t Oct 5, 2016

kennynaoh force-pushed the origamijs branch from e4081f7 to 16b790c Compare October 5, 2016 08:40

add origamijs@0.5.1 and update .gitignore

0a7ae90

npm auto-update config added and update .gitignore to ignore v0.0.2 because v0.0.2 doesn't exist on npm and has no origami.js on git repo, author said he want to forget v0.0.2, close cdnjs#9060, cc @raphamorim

kennynaoh force-pushed the origamijs branch from 16b790c to 0a7ae90 Compare October 5, 2016 08:55

kennynaoh assigned x09326 and unassigned kennynaoh Oct 5, 2016

PeterDaveHello merged commit 5335d26 into cdnjs:master Oct 5, 2016

PeterDaveHello removed the in progress label Oct 5, 2016

kennynaoh deleted the origamijs branch October 12, 2016 11:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add origamijs@0.5.1 and update .gitignore #9108

add origamijs@0.5.1 and update .gitignore #9108

kennynaoh commented Sep 27, 2016 •

edited

x09326 Sep 29, 2016

PeterDaveHello Sep 27, 2016

kennynaoh commented Oct 4, 2016

raphamorim commented Oct 4, 2016

kennynaoh commented Oct 4, 2016

x09326 Oct 4, 2016

raphamorim commented Oct 4, 2016

kennynaoh commented Oct 5, 2016

kennynaoh commented Oct 5, 2016

x09326 commented Oct 5, 2016

PeterDaveHello commented Oct 5, 2016 •

edited

kennynaoh commented Oct 5, 2016 •

edited

PeterDaveHello commented Oct 5, 2016

kennynaoh commented Oct 5, 2016

x09326 commented Oct 5, 2016

add origamijs@0.5.1 and update .gitignore #9108

add origamijs@0.5.1 and update .gitignore #9108

Conversation

kennynaoh commented Sep 27, 2016 • edited

Profile of the lib

Essential checklist

Auto-update checklist

Git commit checklist

x09326 Sep 29, 2016

Choose a reason for hiding this comment

PeterDaveHello Sep 27, 2016

Choose a reason for hiding this comment

kennynaoh commented Oct 4, 2016

raphamorim commented Oct 4, 2016

kennynaoh commented Oct 4, 2016

x09326 Oct 4, 2016

Choose a reason for hiding this comment

raphamorim commented Oct 4, 2016

kennynaoh commented Oct 5, 2016

kennynaoh commented Oct 5, 2016

x09326 commented Oct 5, 2016

PeterDaveHello commented Oct 5, 2016 • edited

kennynaoh commented Oct 5, 2016 • edited

PeterDaveHello commented Oct 5, 2016

kennynaoh commented Oct 5, 2016

x09326 commented Oct 5, 2016

kennynaoh commented Sep 27, 2016 •

edited

PeterDaveHello commented Oct 5, 2016 •

edited

kennynaoh commented Oct 5, 2016 •

edited