Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add currencyformatter.js@1.0.4 w/ npm auto-update #9371

Merged
merged 1 commit into from
Nov 3, 2016

Conversation

nolsherry
Copy link
Contributor

@kennynaoh, please help me review this PR, thanks!

Checklist for Pull request or lib adding request issue follows the conventions.

Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.

Profile of the lib

Essential checklist

  • I'm the author of this library
    • I would like to add link to the page of this library on CDNJS on website / readme
  • This lib was not found on cdnjs repo
  • No already exist / duplicated issue and PR
  • The lib has notable popularity
    • More than 100 [Stars / Watchers / Forks] on [GitHub / Bitbucket]
    • More than 500 downloads stats per month on npm registry
  • Project has public repository on famous online hosting platform (or been hosted on npm)

Auto-update checklist

  • Has valid tags for each versions (for git auto-update)
  • Auto-update setup
  • Auto-update target/source is valid.
  • Auto-update filemap is correct.

Git commit checklist

  • The first line of commit message is less then 50 chars, be clean and clear, easy to understand.
  • The parent of the commit(s) in the PR is not old than 3 days.
  • Pull request is sending from a non-master branch with meaningful name.
  • Separate unrelated changes into different commits.
  • Use rebase to squash/fixup dummy/unnecessary commits into only one commit.
  • Close corresponding issue in commit message
  • Mention related issue(s), people in commit message, comment.

close #9210, cc @osrec

@kennynaoh
Copy link
Contributor

@nolsherry
The latest version on git repo is v1.0.4.
Please confirm with author whether he/she can published the latest version on npm.
Thanks!

@kennynaoh kennynaoh assigned nolsherry and unassigned kennynaoh Oct 24, 2016
@nolsherry
Copy link
Contributor Author

@kennynaoh, OK, I will confirm with the author.

@osrec
Copy link

osrec commented Oct 27, 2016

Latest version published to npm :)

@PeterDaveHello
Copy link
Contributor

@osrec Thanks

@nolsherry
Copy link
Contributor Author

@kennynaoh , I have updated to the latest version v1.0.4, please help me review this PR, thanks!

@nolsherry nolsherry assigned kennynaoh and unassigned nolsherry Nov 2, 2016
@nolsherry nolsherry changed the title add currencyformatter.js@1.0.2 w/ npm auto-update add currencyformatter.js@1.0.4 w/ npm auto-update Nov 2, 2016
Copy link
Contributor

@kennynaoh kennynaoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nolsherry
Please manually add old versions from git repo, because some of versions can't get from npm.
Thanks!

@nolsherry
Copy link
Contributor Author

nolsherry commented Nov 3, 2016

@kennynaoh , the author has updated all versions to npm, please try to use auto-update.js to get all repo versions from npm, thanks!

@kennynaoh
Copy link
Contributor

@nolsherry
Right, there are just two versions on npmcdn.com, but there are all versions on npmjs.com.
Sorry about that.

@kennynaoh
Copy link
Contributor

LGTM
ping @PeterDaveHello

@kennynaoh kennynaoh assigned PeterDaveHello and unassigned kennynaoh Nov 3, 2016
@PeterDaveHello PeterDaveHello merged commit 01d99ae into cdnjs:master Nov 3, 2016
@nolsherry nolsherry deleted the currencyFormatter.js branch November 19, 2016 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Add currencyformatter.js
4 participants