add socket.io v1.7.1 & update auto-update config #9791
Conversation
| @@ -12,10 +12,9 @@ | |||
| "npmName": "socket.io-client", | |||
There was a problem hiding this comment.
@pvnr0082t
Uh...I think this is the right npmName.
How do you think?
There was a problem hiding this comment.
@PeterDaveHello
Is this is the right npmName?
There was a problem hiding this comment.
Isn't it? Is there a the reason for not right?
There was a problem hiding this comment.
socket.io-client looks correct for me
There was a problem hiding this comment.
Because socket.io-client in npm directing to github repo is this.
Maybe we can modify the name and repository of this lib to socket.io-client, I think that will be better.
Or it will confuse socket.io with socket.io-client.
There was a problem hiding this comment.
nope, socker.io it's the main repo, we host its client.
There was a problem hiding this comment.
btw, we could never change the lib name, it'll break the current users.
|
LGTM |
1 similar comment
|
LGTM |
|
not at all since it needs rebase ... |
pvnr0082t
force-pushed
the
update-socket.io
branch
from
44cc9dd
to
8ff8e38
Compare
|
@x09326 @kennynaoh I have rebased it on the latest master branch. Please help me review it again, thank you. |
Pull request for issue: #9772
@x09326 @kennynaoh Please help me review this pull request, thank you.
close #9772