-
-
Notifications
You must be signed in to change notification settings - Fork 213
[Website] Added "Copy Script Tag with SRI" option to library search results #251
Conversation
Hello everyone, I've just read https://news.ycombinator.com/item?id=18559786 TL;DR: Major sites has JavaScript tag without integrity attribute on their payment pages. It would be very useful to see this PR merged, Dropdown menu on the search page https://cdnjs.com/ Dropdown menu on the library page https://cdnjs.com/libraries/jquery Thanks a lot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@PeterDaveHello Could we get this merged? |
@PeterDaveHello Any update please. |
@PeterDaveHello Can you please review this PR, let me know if I need to change anything. |
@Glennmen I'll try to review that ASAP, sorry for the delay. |
@PeterDaveHello Is it worth manually tidying the commits here, or are you good to do a squash merge as this can all be one commit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try it!!
@PeterDaveHello Merge? |
@MattIPv4 Wait a sec, I am now tring to verify the result 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge it now.
@PeterDaveHello & @MattIPv4 Thanks for reviewing and finally getting it merged ❤️ |
@Glennmen Thank you for your contribution 😆 |
@Glennmen Incredibly useful contribution that I am looking forward to making use of personally, so thank you! |
I do have experience in JS but this was the first time I worked with a Node.js project. I would perfectly understand if I made any mistakes.
So I have actually "reported" about this almost a year ago on Twitter and @PeterDaveHello challenged me to make a PR for it. I have never forgotten about it and now because of Hacktoberfest I decided to make some time for it and try it out.
I also saw some open issues about the same issue:
Fixes #152 SRI support on search result
Fixes cdnjs/cdnjs#12746 Add Copy Script Tag with SRI option