New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website] Added "Copy Script Tag with SRI" option to library search results #251

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@Glennmen
Copy link

Glennmen commented Oct 6, 2018

I do have experience in JS but this was the first time I worked with a Node.js project. I would perfectly understand if I made any mistakes.

So I have actually "reported" about this almost a year ago on Twitter and @PeterDaveHello challenged me to make a PR for it. I have never forgotten about it and now because of Hacktoberfest I decided to make some time for it and try it out.

I also saw some open issues about the same issue:
Fixes #152 SRI support on search result
Fixes cdnjs/cdnjs#12746 Add Copy Script Tag with SRI option

Glennmen added some commits Oct 6, 2018

@dadon-david

This comment has been minimized.

Copy link

dadon-david commented Nov 29, 2018

Hello everyone,

I've just read https://news.ycombinator.com/item?id=18559786

TL;DR: Major sites has JavaScript tag without integrity attribute on their payment pages.

It would be very useful to see this PR merged,

Dropdown menu on the search page https://cdnjs.com/
screenshot 2018-11-29 at 17 59 03

Dropdown menu on the library page https://cdnjs.com/libraries/jquery
screenshot 2018-11-29 at 17 59 23

Thanks a lot

@MattIPv4 MattIPv4 referenced this pull request Jan 1, 2019

Closed

A load of updates #262

@MattIPv4
Copy link
Member

MattIPv4 left a comment

LGTM

@MattIPv4 MattIPv4 requested a review from PeterDaveHello Jan 2, 2019

@MattIPv4 MattIPv4 added the enhancement label Jan 2, 2019

@MattIPv4 MattIPv4 changed the title Added "Copy Script Tag with SRI" option to library search results [Website] Added "Copy Script Tag with SRI" option to library search results Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment