Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website] Fix #277: Integrated library name and description in one clickable div #304

Merged
merged 5 commits into from Nov 17, 2019

Conversation

@mpark86
Copy link
Contributor

mpark86 commented Oct 8, 2019

  • Surrounded library name and description in a
    tag when setting up code dynamically
  • Made the
    tag clickable using jQuery
@MattIPv4

This comment has been minimized.

Copy link
Member

MattIPv4 commented Oct 9, 2019

This feels like a super janky solution -- why not just move where the a element is?

@mpark86

This comment has been minimized.

Copy link
Contributor Author

mpark86 commented Oct 9, 2019

Does this look better? I just moved a element to surround the description as well. I also removed all the underlines because it looked a bit messy.

@MattIPv4 MattIPv4 self-requested a review Oct 11, 2019
public/js/main.js Outdated Show resolved Hide resolved
@MattIPv4 MattIPv4 self-requested a review Oct 14, 2019
@mpark86

This comment has been minimized.

Copy link
Contributor Author

mpark86 commented Oct 16, 2019

I committed another change. I think all the points you mentioned are applied to this one? Could you review? Thanks.

public/css/main.css Show resolved Hide resolved
public/css/main.css Outdated Show resolved Hide resolved
public/css/main.css Outdated Show resolved Hide resolved
@mpark86

This comment has been minimized.

Copy link
Contributor Author

mpark86 commented Oct 16, 2019

All done! This actually looks better.

@MattIPv4 MattIPv4 self-requested a review Oct 21, 2019
Copy link
Member

MattIPv4 left a comment

Lgtm.

@MattIPv4 MattIPv4 changed the title Fix #277: Integrated library name and description in one clickable div [Website] Fix #277: Integrated library name and description in one clickable div Nov 14, 2019
@PeterDaveHello PeterDaveHello merged commit a6310af into cdnjs:master Nov 17, 2019
2 checks passed
2 checks passed
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.