This repository has been archived by the owner on Sep 10, 2020. It is now read-only.
[Website] Fix #277: Integrated library name and description in one clickable div #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mpark86
commented
Oct 8, 2019
mpark86
commented
- Surrounded library name and description in a tag when setting up code dynamically
- Made the tag clickable using jQuery
|
This feels like a super janky solution -- why not just move where the |
|
Does this look better? I just moved |
MattIPv4
suggested changes
Oct 12, 2019
|
I committed another change. I think all the points you mentioned are applied to this one? Could you review? Thanks. |
MattIPv4
suggested changes
Oct 16, 2019
|
All done! This actually looks better. |
MattIPv4
changed the title
PeterDaveHello
approved these changes
Nov 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.