Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reveal.js w/ git auto-update #335

Merged
merged 5 commits into from
Jul 16, 2020
Merged

Conversation

hakimel
Copy link
Contributor

@hakimel hakimel commented Jul 8, 2020

We relocated most of our distributed assets in reveal.js 4.0. This PR updates the filemap to cover the new paths.

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other thing to consider, we could pull the files from dist up a directory, so that they are in the root on cdnjs, and then still have plugin as a subdirectory of that?

This doesn't need a change in the source repo, just a change in the auto-update config here, if it seems like the right thing to do from your perspective?

packages/r/reveal.js.json Outdated Show resolved Hide resolved
packages/r/reveal.js.json Outdated Show resolved Hide resolved
@MattIPv4 MattIPv4 changed the title Update reveal.js filemap to match reveal.js 4.x Update reveal.js w/ git auto-update Jul 11, 2020
only include required file types

Co-authored-by: Matt (IPv4) Cowley <me@mattcowley.co.uk>
@hakimel
Copy link
Contributor Author

hakimel commented Jul 12, 2020

Thanks for reviewing. Moving the files in dist up to the root makes sense to me. Is this the right way to configure it?

"fileMap": [
  {
    "basePath": "dist",
    "files": [
      "**/*.@(js|css|eot|ttf|woff)",
      "../plugin/**/*.@(js|css)"
    ]
  }
]

@MattIPv4
Copy link
Member

@hakimel To also include plugins, you'd use a second fileMap, so it'd look like this:

"fileMap": [
  {
    "basePath": "dist",
    "files": [
      "**/*.@(js|css|eot|ttf|woff)"
    ]
  },
  {
    "basePath": "",
    "files": [
      "plugin/**/*.@(js|css)"
    ]
  }
]

This would result in all the files in dist being at the root of the library version in cdnjs, with plugin being a subdirectory still.

@hakimel
Copy link
Contributor Author

hakimel commented Jul 16, 2020

Thanks @MattIPv4. This should be all set now unless you have any other comments.

packages/r/reveal.js.json Outdated Show resolved Hide resolved
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants