-
-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update reveal.js w/ git auto-update #335
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One other thing to consider, we could pull the files from dist
up a directory, so that they are in the root on cdnjs, and then still have plugin
as a subdirectory of that?
This doesn't need a change in the source repo, just a change in the auto-update config here, if it seems like the right thing to do from your perspective?
only include required file types Co-authored-by: Matt (IPv4) Cowley <me@mattcowley.co.uk>
Thanks for reviewing. Moving the files in "fileMap": [
{
"basePath": "dist",
"files": [
"**/*.@(js|css|eot|ttf|woff)",
"../plugin/**/*.@(js|css)"
]
}
] |
@hakimel To also include plugins, you'd use a second fileMap, so it'd look like this: "fileMap": [
{
"basePath": "dist",
"files": [
"**/*.@(js|css|eot|ttf|woff)"
]
},
{
"basePath": "",
"files": [
"plugin/**/*.@(js|css)"
]
}
] This would result in all the files in |
Thanks @MattIPv4. This should be all set now unless you have any other comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Thank you!
We relocated most of our distributed assets in reveal.js 4.0. This PR updates the filemap to cover the new paths.