Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

path to docs and files in the backend #44

Closed
jemont opened this issue Aug 27, 2017 · 7 comments
Closed

path to docs and files in the backend #44

jemont opened this issue Aug 27, 2017 · 7 comments

Comments

@jemont
Copy link

jemont commented Aug 27, 2017

hi,
on bolt 3.3(.2) the pass to the backend link docs and files is 'extensions' and not 'extend'
results in a 404 error
the path to extend still works but bolt opens extenstions

in the docs is a little typo
for the lazyload example you missed the closing round parentheses ')'

@cdowdy
Copy link
Owner

cdowdy commented Aug 27, 2017

Well that is an unexpected change in a minor version of bolt. Thanks for the heads up @jemont ! And thanks for the code example bug lol I always miss something like that! Thanks!

For my future reference this is the relevant bolt change bolt/bolt#6156 and I could have sworn they were using semver and a 3.2 --> 3.3 would be a minor version change that's backwards compatible and clearly this change to bolt core isn't backwards compatible 😞

@jemont
Copy link
Author

jemont commented Aug 27, 2017

hi, asking here since this is not an issue
is there a way to make thumbs permanent and not be deleted after a year
maybe in the named configuration group?

@cdowdy
Copy link
Owner

cdowdy commented Aug 28, 2017

is there a way to make thumbs permanent and not be deleted after a year
maybe in the named configuration group?

Through the betterthumbs configuration no.. The 1 year expiration comes from Glide - specifically https://github.com/thephpleague/glide/blob/8077f529a07ded3eed6c5dcf7f688249b626ddf3/src/Server.php#L463-L479 and I don't see any place to over ride that.

In Glide 2.0 (currently being worked on) You'll be able to set the expires differently since the file structure and how the modifications are used are different.

@jemont
Copy link
Author

jemont commented Aug 28, 2017

ok thanks,
by the way using data-sizes="auto"in lazyload images, doesn't load bigger images when you switch from portrait to landscape. withaout data-sizes="auto" it does

@cdowdy
Copy link
Owner

cdowdy commented Aug 28, 2017

by the way using data-sizes="auto"in lazyload images, doesn't load bigger images when you switch from portrait to landscape. withaout data-sizes="auto" it does

ok you'll have to head over to lazysizes repo (https://github.com/aFarkas/lazysizes) and see if that's expected behavior and make sure you're using the width descriptor and have the recommended markup patterns shown there

@cdowdy
Copy link
Owner

cdowdy commented Aug 29, 2017

This is going to take some time unfortunately.... I can't just "change" the back end route since I have to have a bolt 3.3 install and they changed how extensions are loaded and in turn how you have to develop them so I can't just open up my old development environment and push this really small change for the back end route. I have to setup up my development environment again and in turn all the other extensions I have.

bolt/bolt#6156

@cdowdy
Copy link
Owner

cdowdy commented Sep 14, 2017

Bolt's compare method is wonky and gives the wrong result for bolt < 3.3

This:

protected function registerBackendControllers()
{
$config = $this->getConfig();
if ( Version::compare('3.3.0', '>=')) {
return [
'/extensions/betterthumbs' => new BetterThumbsBackendController( $config ),
];
} else {
return [
'/extend/betterthumbs' => new BetterThumbsBackendController( $config ),
];
}
}

Is wrong for bolt 3.2.x series and probably lower

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants