Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heads-up - planned deprecation of constants #43

Closed
jcallaghan opened this issue Dec 29, 2023 · 1 comment · Fixed by #46
Closed

Heads-up - planned deprecation of constants #43

jcallaghan opened this issue Dec 29, 2023 · 1 comment · Fixed by #46

Comments

@jcallaghan
Copy link

jcallaghan commented Dec 29, 2023 •
edited
Loading

Version of the custom_component

Latest.

Bestway device

NA

Describe the bug

Testing 2024.1 Beta and caught this in the logs about planned deprecation of constants in 2025. Thanks for your work on this integration and HNY!

Logs


TEMP_FAHRENHEIT was used from bestway, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfTemperature.FAHRENHEIT instead, please create a bug report at https://github.com/cdpuk/ha-bestway/issues
@cdpuk
Copy link
Owner

cdpuk commented Jan 4, 2024

Thanks. I'll be sure to sort that out at some point soon. In any case well before 2025 😄

@cdpuk cdpuk linked a pull request Jan 5, 2024 that will close this issue
Support for Airjet_V01 and Hydrojet devices #46
Merged
@cdpuk cdpuk closed this as completed in #46 Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support for Airjet_V01 and Hydrojet devices cdpuk/ha-bestway
2 participants
@jcallaghan @cdpuk