Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run evaluation script with bert sklearn wrapper to check metrics are consistent with run_squad script #70

Closed
fmikaelian opened this issue Mar 8, 2019 · 2 comments
Closed

Run evaluation script with bert sklearn wrapper to check metrics are consistent with run_squad script #70

fmikaelian opened this issue Mar 8, 2019 · 2 comments
Assignees
@andrelmfarias @osans-tel @TNazon @mamrou
Labels
priority: critical 1️⃣ status: approved 🎉 status: good first issue 🐣 status: help wanted 👋 tag: backend 🏭 type: enhancement 💡

Comments

@fmikaelian
Copy link
Collaborator

fmikaelian commented Mar 8, 2019 •
edited
Loading

@andrelmfarias How did you generate metrics.json previously?
@fmikaelian fmikaelian changed the title Run evaluation script bert sklearn wrapper to check metrics are consistent with run_squad script Run evaluation script with bert sklearn wrapper to check metrics are consistent with run_squad script Mar 8, 2019
@fmikaelian fmikaelian mentioned this issue Mar 9, 2019
Closed
@fmikaelian
Copy link
Collaborator Author

fmikaelian commented Mar 11, 2019 •
edited
Loading

To be added in README:

python evaluate-v1.1.py data/dev-v1.1.json logs/bert_qa_squad_v1.1_sklearn/predictions.json

@andrelmfarias
Copy link
Collaborator

andrelmfarias commented Apr 16, 2019 •
edited
Loading

Running predictions for the model version with sklearn wrapper on the squad development set showed metrics comparable to the official hugging face version:

{"exact_match": 81.2488174077578, "f1": 88.43242225358777}

This shows the sklearn wrapper is well implemented and works correctly.

@fmikaelian fmikaelian mentioned this issue May 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrelmfarias andrelmfarias

@osans-tel osans-tel

@TNazon TNazon

@mamrou mamrou

Labels
priority: critical 1️⃣ status: approved 🎉 status: good first issue 🐣 status: help wanted 👋 tag: backend 🏭 type: enhancement 💡
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fmikaelian @andrelmfarias @osans-tel @TNazon @mamrou