Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A file shouldn't be opened as a folder #249

Closed
outloudvi opened this issue Mar 15, 2019 · 4 comments
Closed

A file shouldn't be opened as a folder #249

outloudvi opened this issue Mar 15, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@outloudvi
Copy link

  • code-server version: Docker version
  • OS Version: Ubuntu 18.10 (docker); Manjaro Linux (host)

Description

User should not be able to open a file in "Open Folder". This doesn't work and brings about some side-effects (like the terminal won't open with an error of "chdir: not a directory").

Steps to Reproduce

  1. "File" > "Open Folder..."
  2. Select a file
@outloudvi outloudvi added the bug Something isn't working label Mar 15, 2019
@nol166
Copy link
Contributor

nol166 commented Mar 21, 2019

Interesting. The open folder option seems to be missing on Mac.

@Kiricon
Copy link

Kiricon commented Apr 13, 2019

Interesting. The open folder option seems to be missing on Mac.

I am having this exact same issue

@MichaelDesantis
Copy link
Contributor

@Kiricon What version of the binary are you running?

@code-asher
Copy link
Member

VS Code displays different options based on OS. We will most likely unify them: #501

code-asher added a commit that referenced this issue Jun 19, 2019
@code-asher
Fix some open file/folder issues
627182e 
- "Open folder" now says "open folder" instead of "open file"
- "Open folder" won't allow you to open files
- "Open file" won't allow you to open directories

Fixes #249.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nol166 @Kiricon @MichaelDesantis @outloudvi @code-asher