Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the logging levels #72

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Document the logging levels #72

merged 1 commit into from
Dec 12, 2019

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Dec 12, 2019

Closes #71

@nhooyr nhooyr requested a review from ammario December 12, 2019 00:48
ammario
ammario requested changes Dec 12, 2019
View reviewed changes
sloggers/slogstackdriver/slogstackdriver.go Outdated
@@ -85,7 +85,7 @@ func sev(level slog.Level) logpbtype.LogSeverity {
case slog.LevelError:
return logpbtype.LogSeverity_ERROR
default:
return logpbtype.LogSeverity_CRITICAL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Document

@nhooyr nhooyr merged commit 8f021e1 into master Dec 12, 2019
@nhooyr nhooyr deleted the docs branch December 12, 2019 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammario ammario ammario requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define each log level
2 participants
@nhooyr @ammario