New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Worker heartbeat crashes with "type 'NoneType' is not iterable" #41

Closed

deustis opened this issue Apr 7, 2022 · 1 comment

deustis commented Apr 7, 2022

We're seeing occasional instances of these crashes in production running the pypi version 0.5.1

Looks like a bug on this line:
https://github.com/cdrx/faktory_worker_python/blob/master/faktory/worker.py#L341

    def heartbeat(self) -> None:
        ...
        ok = next(self.faktory.get_message())
        if "state" in ok:

ok is being assigned None. The next line crashes with type 'NoneType' is not iterable

The text was updated successfully, but these errors were encountered:

cdrx closed this as completed in

056d045

Author

deustis commented May 2, 2022

@cdrx, thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment