Prefix thread names #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thread names appear in logs. The default naming scheme is something like `ThreadPoolExecutor_x_y`, with `x` enumerating `ThreadPoolExecutor` and `y` enumerating threads. This changes the thread name into something more recognizable, especially in environments where other named threads are operating.
|
Thank you for your contributions @antoine-gallix |
|
Great! Apart from doc improvements in other projects, I think it's my first code contribution ever to be merged! If you are curious to know where your code is running, we use your package in the NGO I work in to build this product. We have a ruby backend with a python data processing part, and we use faktory for background jobs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread names appear in logs. The default naming scheme is something like
ThreadPoolExecutor_x_y, withxenumeratingThreadPoolExecutorandyenumerating threads. This changes the thread name into something more recognizable, especially in environments where other named threads are operating.Worker_0,Worker_1, etc.Faktorycould also be an alternative naming. The standard seems to be camel case names for threads.