Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing return statements #112

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Add missing return statements #112

merged 1 commit into from
Nov 7, 2023

Conversation

lpsinger
Copy link
Contributor

No description provided.

@ManonMarchand ManonMarchand mentioned this pull request Oct 28, 2023
Closed
@ManonMarchand
Copy link
Member

Thanks! We'll merge it one we repair our CI (see #113).

@fxpineau fxpineau merged commit 1ed605a into cds-astro:master Nov 7, 2023
2 of 14 checks passed
@fxpineau
Copy link
Member

fxpineau commented Nov 7, 2023

It seems that those errors are due to someone used to Rust (no return needed and compile time catch errors) 😅.
Thank you @lpsinger for the PR.

@lpsinger lpsinger deleted the missing-return-statements branch November 7, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lpsinger @ManonMarchand @fxpineau