Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop seaborn dependency #68

Merged
merged 5 commits into from
Nov 29, 2023
Merged

Drop seaborn dependency #68

merged 5 commits into from
Nov 29, 2023

Conversation

ManonMarchand
Copy link
Member

@ManonMarchand ManonMarchand commented Nov 29, 2023

This switches from seaborn to matplotlib for the plots of tutorial 3. This is coming from the following reasons:

  • this is not really the place to learn how to plot, so staying with vanilla matplotlib is no issue here
  • this removes a dependency : seaborn
  • seaborn do something with indexing that causes issues for fits files (due to reversed byteorder)

@ManonMarchand ManonMarchand changed the title Drop pandas dependency Drop seaborn dependency Nov 29, 2023
@ManonMarchand ManonMarchand merged commit 24909ec into master Nov 29, 2023
8 of 9 checks passed
@ManonMarchand ManonMarchand deleted the fix-plots-in-notebook3 branch November 29, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant