This repository has been archived by the owner on May 7, 2021. It is now read-only.
Add UUID to the logs per session #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding to request.locals seems to be the way to go according to this stack overflow answer. - https://stackoverflow.com/questions/33451053/req-locals-vs-res-locals-vs-res-data-vs-req-data-vs-app-locals-in-express-mi
Lots of noise and we don't need it.
dsamojlenko
approved these changes
Apr 2, 2020
|
boom 💥 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an id to the session per user, and then adds the id to the logs in production.
The way to clear your session is to visit the
/clearURL, which removes the session and then you will get a new ID.Here's what the logs look like in prod for the first two URLs.
Added the UUID package because it has like a bazillion downloads.
Closes #46