Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Adding a suffix to the title + change the /code page to be /number #91

Merged
merged 6 commits into from
Jul 14, 2020
Merged

Adding a suffix to the title + change the /code page to be /number #91

merged 6 commits into from
Jul 14, 2020

Conversation

PierrePaul
Copy link
Contributor

@PierrePaul PierrePaul commented Jul 13, 2020 •
edited
Loading

https://trello.com/c/HRE3hfbf/120-title-tag-should-have-trailing-covid-alert-portal

Adds a new title suffix block with sensible defaults.

Also fixes https://trello.com/c/AVIwnNby/134-change-code-url-to-number
Changes the /code page to /number to prevent confusion.

@PierrePaul PierrePaul requested a review from a team as a code owner July 13, 2020 19:42
@pcraig3 pcraig3 temporarily deployed to healthcare-p-feature-up-vrkyni July 13, 2020 19:42 Inactive
@pcraig3 pcraig3 temporarily deployed to healthcare-p-feature-up-vrkyni July 13, 2020 19:48 Inactive
@PierrePaul PierrePaul changed the title Adding a suffix to the title Adding a suffix to the title + change the /code page to be /number Jul 13, 2020
@pcraig3 pcraig3 temporarily deployed to healthcare-p-feature-up-vrkyni July 13, 2020 19:52 Inactive
pcraig3
pcraig3 reviewed Jul 14, 2020
View reviewed changes
Copy link
Contributor

@pcraig3 pcraig3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of our tests are looking at the code page, so once those are fixed this can go in.

@pcraig3 pcraig3 temporarily deployed to healthcare-p-feature-up-vrkyni July 14, 2020 13:43 Inactive
@pcraig3 pcraig3 temporarily deployed to healthcare-p-feature-up-vrkyni July 14, 2020 13:48 Inactive
@pcraig3 pcraig3 temporarily deployed to healthcare-p-feature-up-vrkyni July 14, 2020 14:00 Inactive
pcraig3
pcraig3 approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@pcraig3 pcraig3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@PierrePaul PierrePaul merged commit 39e0fcf into main Jul 14, 2020
@pcraig3 pcraig3 deleted the feature-update-title branch July 15, 2020 16:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pcraig3 pcraig3 pcraig3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PierrePaul @pcraig3