This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Adds Heroku PR Review apps #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set buildpack in proper place Add Procfile Try relative path Try docker Move up stack Define User Add user and uid Try without user on heroku Set addon Parse JAWS_DB Add some debug Push to stderr lern2bash Explicit pass more radical Try with a new app Remove default command Try without heroku run command Relative executable Complete path Proper base container for a bash script :facepalm" Add port split Add stdout metrics Add success URL sync command Another location for success_url Fix stdout
maxneuvians
changed the title
dsamojlenko
approved these changes
Jul 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds Heroku PR review apps to the repository. (https://devcenter.heroku.com/articles/github-integration-review-apps)
This allows us to test against builds based on the PR code that are hosted in the cloud vs. on developer machines. The review apps make use of the
monolithbuild which includes both thesubmissionandretrievalendpoints. It also uses a SAAS DB cloud provider called JawsDB. JawsDB provides an environment variable with the connection string. As Go requires a specific connection string format, we munge the environment variable into the correct format with a script before we boot the server.The environment variables for the app itself are the same as for the docker-compose, or local dev, environments.