Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TXT record to verify domain #245

Merged
merged 3 commits into from
Apr 27, 2022
Merged

Conversation

ethanWallace
Copy link
Contributor

Summary | Résumé

Add TXT record to verify the ownership of domain with Netlify.

@github-actions
Copy link

DNS

✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

⚠️   WARNING: resources will be destroyed by this change!

Plan: 2 to add, 0 to change, 1 to destroy
Show plan
Resource actions are indicated with the following symbols:
  + create
  - destroy

Terraform will perform the following actions:

  # aws_route53_record.design-alpha-canada-ca-A will be destroyed
  - resource "aws_route53_record" "design-alpha-canada-ca-A" {
      - fqdn    = "design.alpha.canada.ca" -> null
      - id      = "Z33C47YI9EN8XL_design.alpha.canada.ca_CNAME" -> null
      - name    = "design.alpha.canada.ca" -> null
      - records = [
          - "gallant-bassi-851d24.netlify.app",
        ] -> null
      - ttl     = 300 -> null
      - type    = "CNAME" -> null
      - zone_id = "Z33C47YI9EN8XL" -> null
    }

  # aws_route53_record.design-alpha-canada-ca-CNAME will be created
  + resource "aws_route53_record" "design-alpha-canada-ca-CNAME" {
      + allow_overwrite = (known after apply)
      + fqdn            = (known after apply)
      + id              = (known after apply)
      + name            = "design.alpha.canada.ca"
      + records         = [
          + "gallant-bassi-851d24.netlify.app",
        ]
      + ttl             = 300
      + type            = "CNAME"
      + zone_id         = "Z33C47YI9EN8XL"
    }

  # aws_route53_record.design-alpha-canada-ca-TXT will be created
  + resource "aws_route53_record" "design-alpha-canada-ca-TXT" {
      + allow_overwrite = (known after apply)
      + fqdn            = (known after apply)
      + id              = (known after apply)
      + name            = "design.alpha.canada.ca"
      + records         = [
          + "91447",
        ]
      + ttl             = 300
      + type            = "TXT"
      + zone_id         = "Z33C47YI9EN8XL"
    }

Plan: 2 to add, 0 to change, 1 to destroy.

------------------------------------------------------------------------

This plan was saved to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"

Show Conftest results
WARN - plan.json - main - Missing Common Tags: ["aws_route53_zone.alpha-canada-ca-public"]
WARN - plan.json - main - Missing Common Tags: ["aws_route53_zone.cds-snc-ca-public"]
WARN - plan.json - main - Missing Common Tags: ["aws_route53_zone.notification-canada-ca-public"]

19 tests, 16 passed, 3 warnings, 0 failures, 0 exceptions

Copy link
Member

@patheard patheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

@ethanWallace ethanWallace merged commit 90188cf into main Apr 27, 2022
@ethanWallace ethanWallace deleted the design-alpha-verify-domain branch April 27, 2022 17:53
@ethanWallace
Copy link
Contributor Author

Looks like the terraform apply received an error, so I don't think these changes applied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants