chore: GCForms release v3.10.2 #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sre-read-write[bot]](https://avatars.githubusercontent.com/in/146819?s=60&v=4){kind=small}
sre-read-write
bot
requested review from
bryan-robitaille,
dsamojlenko,
timarney and
craigzour
as code owners
sre-read-write
bot
force-pushed
the
release-please--branches--develop
branch
from
f52dacf
to
3690e50
Compare
Production: oidc_roles✅ Terraform Init: Plan: 0 to add, 0 to change, 2 to destroyShow summary
Show planResource actions are indicated with the following symbols:
- destroy
Terraform will perform the following actions:
# aws_iam_role_policy_attachment.forms_terraform_apply_release_admin[0] will be destroyed
# (because aws_iam_role_policy_attachment.forms_terraform_apply_release_admin is not in configuration)
- resource "aws_iam_role_policy_attachment" "forms_terraform_apply_release_admin" {
- id = "forms-terraform-apply-release-20240125150109702600000001" -> null
- policy_arn = "arn:aws:iam::aws:policy/AdministratorAccess" -> null
- role = "forms-terraform-apply-release" -> null
}
# module.github_workflow_roles.aws_iam_role.this["forms-terraform-apply-release"] will be destroyed
# (because key ["forms-terraform-apply-release"] is not in for_each map)
- resource "aws_iam_role" "this" {
- arn = "arn:aws:iam::957818836222:role/forms-terraform-apply-release" -> null
- assume_role_policy = jsonencode(
{
- Statement = [
- {
- Action = "sts:AssumeRoleWithWebIdentity"
- Condition = {
- StringLike = {
- "token.actions.githubusercontent.com:sub" = "repo:cds-snc/forms-terraform:ref:refs/tags/v*"
}
}
- Effect = "Allow"
- Principal = {
- Federated = "arn:aws:iam::957818836222:oidc-provider/token.actions.githubusercontent.com"
}
},
]
- Version = "2012-10-17"
}
) -> null
- create_date = "2024-01-25T15:01:09Z" -> null
- force_detach_policies = false -> null
- id = "forms-terraform-apply-release" -> null
- managed_policy_arns = [
- "arn:aws:iam::aws:policy/AdministratorAccess",
] -> null
- max_session_duration = 3600 -> null
- name = "forms-terraform-apply-release" -> null
- path = "/" -> null
- tags = {
- "CostCentre" = "forms-platform-production"
- "Terraform" = "true"
} -> null
- tags_all = {
- "CostCentre" = "forms-platform-production"
- "Terraform" = "true"
} -> null
- unique_id = "AROA56ATTST7LCYQIKKSO" -> null
}
Plan: 0 to add, 0 to change, 2 to destroy.
─────────────────────────────────────────────────────────────────────────────
Saved the plan to: plan.tfplan
To perform exactly these actions, run the following command to apply:
terraform apply "plan.tfplan"
Show Conftest resultsWARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.platform_forms_client_release[0]"]
20 tests, 19 passed, 1 warning, 0 failures, 0 exceptions
|
Production: app✅ Terraform Init: Plan: 1 to add, 0 to change, 1 to destroyShow summary
Show planResource actions are indicated with the following symbols:
-/+ destroy and then create replacement
Terraform will perform the following actions:
# aws_ecs_task_definition.form_viewer must be replaced
-/+ resource "aws_ecs_task_definition" "form_viewer" {
~ arn = "arn:aws:ecs:ca-central-1:957818836222:task-definition/form-viewer:71" -> (known after apply)
~ arn_without_revision = "arn:aws:ecs:ca-central-1:957818836222:task-definition/form-viewer" -> (known after apply)
~ container_definitions = jsonencode(
~ [
~ {
- cpu = 0
- essential = true
~ linuxParameters = {
~ capabilities = {
- add = []
# (1 unchanged attribute hidden)
}
}
- mountPoints = []
name = "form_viewer"
~ portMappings = [
~ {
- hostPort = 3000
- protocol = "tcp"
# (1 unchanged attribute hidden)
},
]
- systemControls = []
- volumesFrom = []
# (4 unchanged attributes hidden)
},
] # forces replacement
)
~ id = "form-viewer" -> (known after apply)
~ revision = 71 -> (known after apply)
- tags = {} -> null
# (9 unchanged attributes hidden)
}
Plan: 1 to add, 0 to change, 1 to destroy.
─────────────────────────────────────────────────────────────────────────────
Saved the plan to: plan.tfplan
To perform exactly these actions, run the following command to apply:
terraform apply "plan.tfplan"
Show Conftest resultsWARN - plan.json - main - Missing Common Tags: ["aws_appautoscaling_target.forms[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.forms"]
WARN - plan.json - main - Missing Common Tags: ["aws_codedeploy_app.app"]
WARN - plan.json - main - Missing Common Tags: ["aws_codedeploy_deployment_group.app"]
WARN - plan.json - main - Missing Common Tags: ["aws_ecs_cluster.forms"]
WARN - plan.json - main - Missing Common Tags: ["aws_ecs_service.form_viewer"]
WARN - plan.json - main - Missing Common Tags: ["aws_ecs_task_definition.form_viewer"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.cognito"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.forms_dynamodb"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.forms_kms"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.forms_s3"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.forms_secrets_manager"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.forms_sqs"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.codedeploy"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.forms"]
34 tests, 19 passed, 15 warnings, 0 failures, 0 exceptions
|
bryan-robitaille
approved these changes
Jun 18, 2024
Production: alarms✅ Terraform Init: Plan: 0 to add, 0 to change, 18 to destroyShow summary
Show planResource actions are indicated with the following symbols:
- destroy
Terraform will perform the following actions:
# aws_cloudwatch_log_metric_filter.healthcheck["ClientSubmitFailed"] will be destroyed
# (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
- resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
- id = "ClientSubmitFailed" -> null
- log_group_name = "Forms" -> null
- name = "ClientSubmitFailed" -> null
- pattern = "Attempted response submission for Form ID" -> null
- metric_transformation {
- default_value = "0" -> null
- dimensions = {} -> null
- name = "ClientSubmitFailed" -> null
- namespace = "forms" -> null
- unit = "Count" -> null
- value = "1" -> null
}
}
# aws_cloudwatch_log_metric_filter.healthcheck["ClientSubmitSuccess"] will be destroyed
# (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
- resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
- id = "ClientSubmitSuccess" -> null
- log_group_name = "Forms" -> null
- name = "ClientSubmitSuccess" -> null
- pattern = "Response submitted for Form ID" -> null
- metric_transformation {
- default_value = "0" -> null
- dimensions = {} -> null
- name = "ClientSubmitSuccess" -> null
- namespace = "forms" -> null
- unit = "Count" -> null
- value = "1" -> null
}
}
# aws_cloudwatch_log_metric_filter.healthcheck["FormArchiverFailed"] will be destroyed
# (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
- resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
- id = "FormArchiverFailed" -> null
- log_group_name = "/aws/lambda/Archive_Form_Templates" -> null
- name = "FormArchiverFailed" -> null
- pattern = "{$.status = \"failed\"}" -> null
- metric_transformation {
- default_value = "0" -> null
- dimensions = {} -> null
- name = "FormArchiverFailed" -> null
- namespace = "forms" -> null
- unit = "Count" -> null
- value = "1" -> null
}
}
# aws_cloudwatch_log_metric_filter.healthcheck["FormArchiverSuccess"] will be destroyed
# (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
- resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
- id = "FormArchiverSuccess" -> null
- log_group_name = "/aws/lambda/Archive_Form_Templates" -> null
- name = "FormArchiverSuccess" -> null
- pattern = "{$.status = \"success\"}" -> null
- metric_transformation {
- default_value = "0" -> null
- dimensions = {} -> null
- name = "FormArchiverSuccess" -> null
- namespace = "forms" -> null
- unit = "Count" -> null
- value = "1" -> null
}
}
# aws_cloudwatch_log_metric_filter.healthcheck["FormArchiverWarn"] will be destroyed
# (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
- resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
- id = "FormArchiverWarn" -> null
- log_group_name = "/aws/lambda/Archive_Form_Templates" -> null
- name = "FormArchiverWarn" -> null
- pattern = "{$.level = \"warn\"}" -> null
- metric_transformation {
- default_value = "0" -> null
- dimensions = {} -> null
- name = "FormArchiverWarn" -> null
- namespace = "forms" -> null
- unit = "Count" -> null
- value = "1" -> null
}
}
# aws_cloudwatch_log_metric_filter.healthcheck["ReliabilityFailed"] will be destroyed
# (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
- resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
- id = "ReliabilityFailed" -> null
- log_group_name = "/aws/lambda/Reliability" -> null
- name = "ReliabilityFailed" -> null
- pattern = "{$.status = \"failed\"}" -> null
- metric_transformation {
- default_value = "0" -> null
- dimensions = {} -> null
- name = "ReliabilityFailed" -> null
- namespace = "forms" -> null
- unit = "Count" -> null
- value = "1" -> null
}
}
# aws_cloudwatch_log_metric_filter.healthcheck["ReliabilityNotifySendFailed"] will be destroyed
# (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
- resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
- id = "ReliabilityNotifySendFailed" -> null
- log_group_name = "/aws/lambda/Reliability" -> null
- name = "ReliabilityNotifySendFailed" -> null
- pattern = "Failed to send submission through GC Notify" -> null
- metric_transformation {
- default_value = "0" -> null
- dimensions = {} -> null
- name = "ReliabilityNotifySendFailed" -> null
- namespace = "forms" -> null
- unit = "Count" -> null
- value = "1" -> null
}
}
# aws_cloudwatch_log_metric_filter.healthcheck["ReliabilityNotifySendSuccess"] will be destroyed
# (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
- resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
- id = "ReliabilityNotifySendSuccess" -> null
- log_group_name = "/aws/lambda/Reliability" -> null
- name = "ReliabilityNotifySendSuccess" -> null
- pattern = "Successfully sent submission through GC Notify" -> null
- metric_transformation {
- default_value = "0" -> null
- dimensions = {} -> null
- name = "ReliabilityNotifySendSuccess" -> null
- namespace = "forms" -> null
- unit = "Count" -> null
- value = "1" -> null
}
}
# aws_cloudwatch_log_metric_filter.healthcheck["ReliabilitySuccess"] will be destroyed
# (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
- resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
- id = "ReliabilitySuccess" -> null
- log_group_name = "/aws/lambda/Reliability" -> null
- name = "ReliabilitySuccess" -> null
- pattern = "{$.status = \"success\"}" -> null
- metric_transformation {
- default_value = "0" -> null
- dimensions = {} -> null
- name = "ReliabilitySuccess" -> null
- namespace = "forms" -> null
- unit = "Count" -> null
- value = "1" -> null
}
}
# aws_cloudwatch_log_metric_filter.healthcheck["ReliabilityVaultSaveFailed"] will be destroyed
# (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
- resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
- id = "ReliabilityVaultSaveFailed" -> null
- log_group_name = "/aws/lambda/Reliability" -> null
- name = "ReliabilityVaultSaveFailed" -> null
- pattern = "Failed to save submission to Vault" -> null
- metric_transformation {
- default_value = "0" -> null
- dimensions = {} -> null
- name = "ReliabilityVaultSaveFailed" -> null
- namespace = "forms" -> null
- unit = "Count" -> null
- value = "1" -> null
}
}
# aws_cloudwatch_log_metric_filter.healthcheck["ReliabilityVaultSaveSuccess"] will be destroyed
# (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
- resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
- id = "ReliabilityVaultSaveSuccess" -> null
- log_group_name = "/aws/lambda/Reliability" -> null
- name = "ReliabilityVaultSaveSuccess" -> null
- pattern = "Successfully saved submission to Vault" -> null
- metric_transformation {
- default_value = "0" -> null
- dimensions = {} -> null
- name = "ReliabilityVaultSaveSuccess" -> null
- namespace = "forms" -> null
- unit = "Count" -> null
- value = "1" -> null
}
}
# aws_cloudwatch_log_metric_filter.healthcheck["ReliabilityWarn"] will be destroyed
# (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
- resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
- id = "ReliabilityWarn" -> null
- log_group_name = "/aws/lambda/Reliability" -> null
- name = "ReliabilityWarn" -> null
- pattern = "{$.level = \"warn\"}" -> null
- metric_transformation {
- default_value = "0" -> null
- dimensions = {} -> null
- name = "ReliabilityWarn" -> null
- namespace = "forms" -> null
- unit = "Count" -> null
- value = "1" -> null
}
}
# aws_cloudwatch_log_metric_filter.healthcheck["ResponseArchiverFailed"] will be destroyed
# (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
- resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
- id = "ResponseArchiverFailed" -> null
- log_group_name = "/aws/lambda/Response_Archiver" -> null
- name = "ResponseArchiverFailed" -> null
- pattern = "{$.status = \"failed\"}" -> null
- metric_transformation {
- default_value = "0" -> null
- dimensions = {} -> null
- name = "ResponseArchiverFailed" -> null
- namespace = "forms" -> null
- unit = "Count" -> null
- value = "1" -> null
}
}
# aws_cloudwatch_log_metric_filter.healthcheck["ResponseArchiverSuccess"] will be destroyed
# (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
- resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
- id = "ResponseArchiverSuccess" -> null
- log_group_name = "/aws/lambda/Response_Archiver" -> null
- name = "ResponseArchiverSuccess" -> null
- pattern = "{$.status = \"success\"}" -> null
- metric_transformation {
- default_value = "0" -> null
- dimensions = {} -> null
- name = "ResponseArchiverSuccess" -> null
- namespace = "forms" -> null
- unit = "Count" -> null
- value = "1" -> null
}
}
# aws_cloudwatch_log_metric_filter.healthcheck["ResponseArchiverWarn"] will be destroyed
# (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
- resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
- id = "ResponseArchiverWarn" -> null
- log_group_name = "/aws/lambda/Response_Archiver" -> null
- name = "ResponseArchiverWarn" -> null
- pattern = "{$.level = \"warn\"}" -> null
- metric_transformation {
- default_value = "0" -> null
- dimensions = {} -> null
- name = "ResponseArchiverWarn" -> null
- namespace = "forms" -> null
- unit = "Count" -> null
- value = "1" -> null
}
}
# aws_cloudwatch_log_metric_filter.healthcheck["SubmissionFailed"] will be destroyed
# (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
- resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
- id = "SubmissionFailed" -> null
- log_group_name = "/aws/lambda/Submission" -> null
- name = "SubmissionFailed" -> null
- pattern = "{$.status = \"failed\"}" -> null
- metric_transformation {
- default_value = "0" -> null
- dimensions = {} -> null
- name = "SubmissionFailed" -> null
- namespace = "forms" -> null
- unit = "Count" -> null
- value = "1" -> null
}
}
# aws_cloudwatch_log_metric_filter.healthcheck["SubmissionSuccess"] will be destroyed
# (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
- resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
- id = "SubmissionSuccess" -> null
- log_group_name = "/aws/lambda/Submission" -> null
- name = "SubmissionSuccess" -> null
- pattern = "{$.status = \"success\"}" -> null
- metric_transformation {
- default_value = "0" -> null
- dimensions = {} -> null
- name = "SubmissionSuccess" -> null
- namespace = "forms" -> null
- unit = "Count" -> null
- value = "1" -> null
}
}
# aws_cloudwatch_log_metric_filter.healthcheck["SubmissionWarn"] will be destroyed
# (because aws_cloudwatch_log_metric_filter.healthcheck is not in configuration)
- resource "aws_cloudwatch_log_metric_filter" "healthcheck" {
- id = "SubmissionWarn" -> null
- log_group_name = "/aws/lambda/Submission" -> null
- name = "SubmissionWarn" -> null
- pattern = "{$.level = \"warn\"}" -> null
- metric_transformation {
- default_value = "0" -> null
- dimensions = {} -> null
- name = "SubmissionWarn" -> null
- namespace = "forms" -> null
- unit = "Count" -> null
- value = "1" -> null
}
}
Plan: 0 to add, 0 to change, 18 to destroy.
Warning: Argument is deprecated
with module.athena_bucket.aws_s3_bucket.this,
on .terraform/modules/athena_bucket/S3/main.tf line 8, in resource "aws_s3_bucket" "this":
8: resource "aws_s3_bucket" "this" {
Use the aws_s3_bucket_lifecycle_configuration resource instead
(and 3 more similar warnings elsewhere)
─────────────────────────────────────────────────────────────────────────────
Saved the plan to: plan.tfplan
To perform exactly these actions, run the following command to apply:
terraform apply "plan.tfplan"
Show Conftest resultsWARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_event_rule.codedeploy_sns"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.notify_slack"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.ELB_5xx_error_warn"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.UnHealthyHostCount-TargetGroup1"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.UnHealthyHostCount-TargetGroup2"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.alb_ddos"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.audit_log_dead_letter_queue_warn"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.cognito_login_outside_canada_warn"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.cognito_signin_exceeded"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.ddos_detected_forms_warn"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.ddos_detected_route53_warn[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.forms_cpu_utilization_high_warn"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.forms_memory_utilization_high_warn"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.reliability_dead_letter_queue_warn"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.response_time_warn"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.route53_ddos[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.twoFa_verification_exceeded"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.vault_data_integrity_check_lambda_iterator_age"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.notify_slack_lambda"]
WARN - plan.json -... |
19 tasks
|
🤖 Release is at https://github.com/cds-snc/forms-terraform/releases/tag/v3.10.2 🌻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 I have created a release beep boop
3.10.2 (2024-06-18)
Bug Fixes
Miscellaneous Chores
forms-terraform-apply-releaseOIDC role (#696) (69bb7e1)This PR was generated with Release Please. See documentation.