fix: Safari a11y issues with links and nav group focus #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melaniebmn
reviewed
Jul 9, 2024
| text-underline-offset: var(--gcds-link-underline-offset); | ||
| text-decoration-style: solid; | ||
| text-decoration-color: currentColor; | ||
| text-decoration-thickness: var(--gcds-link-decoration-thickness); |
There was a problem hiding this comment.
Seems like this line is getting deleted by accident here - can we put this back in, please?
text-underline-offset: var(--gcds-link-underline-offset);
melaniebmn
requested changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
FIx a couple issues related to how Safari renders and handles focus.
Links not rendering with underline #576
Safari does not accept the
text-decorationshorthand so switched to using all properties.Unable to click nested links in a top-nav nav-group #577
Safari handles focus a little differently from other browsers so the dropdown logic logic would fire before the
nav-linkclick event could be called. Added a small timeout to thefocusoutlistener function to allow thegcds-nav-linkclick to go through.