-
Notifications
You must be signed in to change notification settings - Fork 3
Commits on Dec 6, 2019
-
enable extended body parsing for nested data
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 964fedc - Browse repository at this point
Copy the full SHA 964fedcView commit details -
BREAKING: deprecate
getViewData()
in favour of loadSession=== why? === For the repeater (and other context-sensitive rendering), we will need to access and mutate view data through `res.locals`. This means that all our data needs to be available there. So, instead of passing in data to `res.render(...)`, we consistently use a middleware that loads data into `res.locals`. This results in easier-to-follow code, and it is clearer that the choice of what data to load comes from the schema. For locals that don't appear in the schema, implementers can use `loadKeys(...keys)` or `loadFullSession` to get data from the session, or implement a custom middleware that adds data to `res.locals`. For the vast majority of cases, rendering should be done with the middleware `route.render()`.
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for dd08cff - Browse repository at this point
Copy the full SHA dd08cffView commit details -
add context middleware primitives for data
`enterContext` and `exitContext` allow us to dynamically traverse nested data in the session. Using these, we can change the "context" from which we get data and errors, and automatically generate `name` attributes appropriate for the nested data.
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 5518e9e - Browse repository at this point
Copy the full SHA 5518e9eView commit details -
update all the control macros to use getData(...) etc
this way, the data, error, and name will all be relative to the context.
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 8fb11a5 - Browse repository at this point
Copy the full SHA 8fb11a5View commit details -
use loadFullSession in the confirmation page
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 0acf3d7 - Browse repository at this point
Copy the full SHA 0acf3d7View commit details -
remove the data.* scope in the confirmation page
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 0c28f0d - Browse repository at this point
Copy the full SHA 0c28f0dView commit details -
use the new style controls in the personal route
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for f6f346d - Browse repository at this point
Copy the full SHA f6f346dView commit details -
use the new style for the start page
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for a20138d - Browse repository at this point
Copy the full SHA a20138dView commit details -
warn when referencing a non-existent route
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 846c5b4 - Browse repository at this point
Copy the full SHA 846c5b4View commit details -
this uses `enterContext` and `exitContext` to iterate over the existing data and render the contents statically multiple times on the backend. the frontend will then manage the buttons and re-ordering, in such a way that the data will be posted properly to the server.
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 26675e6 - Browse repository at this point
Copy the full SHA 26675e6View commit details -
add a sample route 'addresses' that uses the repeater
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 23fdf75 - Browse repository at this point
Copy the full SHA 23fdf75View commit details -
http://jneen.net/ committed
Dec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for e19d623 - Browse repository at this point
Copy the full SHA e19d623View commit details -
add a spec for the context helpers
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for eaf000c - Browse repository at this point
Copy the full SHA eaf000cView commit details -
properly implement
isFirstError(relname)
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 5b18e1a - Browse repository at this point
Copy the full SHA 5b18e1aView commit details -
properly use the errorState session key
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 38ae1f2 - Browse repository at this point
Copy the full SHA 38ae1f2View commit details -
expand the contextHelpers spec
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for c8ceada - Browse repository at this point
Copy the full SHA c8ceadaView commit details -
clear the error state on any successful form submission
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for e47fdef - Browse repository at this point
Copy the full SHA e47fdefView commit details -
behave better when req.body has falsey values
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 95a0a1e - Browse repository at this point
Copy the full SHA 95a0a1eView commit details -
http://jneen.net/ committed
Dec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 0d2bce9 - Browse repository at this point
Copy the full SHA 0d2bce9View commit details -
rm a test for an interface that doesn't exist anymore
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 36eca23 - Browse repository at this point
Copy the full SHA 36eca23View commit details -
http://jneen.net/ committed
Dec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 25332ad - Browse repository at this point
Copy the full SHA 25332adView commit details -
properly propagate the errors from the session
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 03e9e8d - Browse repository at this point
Copy the full SHA 03e9e8dView commit details -
we will want something similar to this, but the current implementation is not workable.
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 654f851 - Browse repository at this point
Copy the full SHA 654f851View commit details -
http://jneen.net/ committed
Dec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 73c13f5 - Browse repository at this point
Copy the full SHA 73c13f5View commit details -
add in
mockSession
, a new way to mock the sessionhttp://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for b73a639 - Browse repository at this point
Copy the full SHA b73a639View commit details -
protect against cases in tests where there is no session
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 9c5bf35 - Browse repository at this point
Copy the full SHA 9c5bf35View commit details -
http://jneen.net/ committed
Dec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 361d4e5 - Browse repository at this point
Copy the full SHA 361d4e5View commit details -
rely on res.locals.firstError in
isFirstError
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for aeefec0 - Browse repository at this point
Copy the full SHA aeefec0View commit details -
http://jneen.net/ committed
Dec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for e44a04f - Browse repository at this point
Copy the full SHA e44a04fView commit details -
http://jneen.net/ committed
Dec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 2a2143a - Browse repository at this point
Copy the full SHA 2a2143aView commit details -
http://jneen.net/ committed
Dec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 0992bfe - Browse repository at this point
Copy the full SHA 0992bfeView commit details -
http://jneen.net/ committed
Dec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 2e900ad - Browse repository at this point
Copy the full SHA 2e900adView commit details -
http://jneen.net/ committed
Dec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 22ed9d7 - Browse repository at this point
Copy the full SHA 22ed9d7View commit details -
http://jneen.net/ committed
Dec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 5367470 - Browse repository at this point
Copy the full SHA 5367470View commit details -
http://jneen.net/ committed
Dec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for da957c0 - Browse repository at this point
Copy the full SHA da957c0View commit details -
add unique identifiers and styling to repeaters
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 2497783 - Browse repository at this point
Copy the full SHA 2497783View commit details -
allow pressing spacebar to activate the repeat and remove-repeat links
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 5106865 - Browse repository at this point
Copy the full SHA 5106865View commit details -
standardize on
client.js
for client javascriptand have it automatically loaded if the file exists
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 9578768 - Browse repository at this point
Copy the full SHA 9578768View commit details -
update repeater.js to es6 style
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 1585efa - Browse repository at this point
Copy the full SHA 1585efaView commit details -
http://jneen.net/ committed
Dec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 6143c05 - Browse repository at this point
Copy the full SHA 6143c05View commit details -
better keyboard navigation behaviour
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 771cdc5 - Browse repository at this point
Copy the full SHA 771cdc5View commit details -
move polyfill scripts to assets/js/
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 3abc290 - Browse repository at this point
Copy the full SHA 3abc290View commit details -
move the only remaining nunjucks script to googleAnalytics.njk
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for daae75f - Browse repository at this point
Copy the full SHA daae75fView commit details -
add assets/js/ to the default module path for client js
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 88a4d27 - Browse repository at this point
Copy the full SHA 88a4d27View commit details -
add translations for the addresses page and fix confirmation
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for a28a606 - Browse repository at this point
Copy the full SHA a28a606View commit details -
remove the push hooks - we will rely on CI
http://jneen.net/ committedDec 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 10c35e5 - Browse repository at this point
Copy the full SHA 10c35e5View commit details
Commits on Dec 9, 2019
-
disable import-checking in eslint
bad imports should be caught immediately in testing anyways
http://jneen.net/ committedDec 9, 2019 Configuration menu - View commit details
-
Copy full SHA for 9892891 - Browse repository at this point
Copy the full SHA 9892891View commit details -
use modern variable scoping in repeater.js
http://jneen.net/ committedDec 9, 2019 Configuration menu - View commit details
-
Copy full SHA for f8c323e - Browse repository at this point
Copy the full SHA f8c323eView commit details -
use template strings in repeater.js
http://jneen.net/ committedDec 9, 2019 Configuration menu - View commit details
-
Copy full SHA for 8f1de10 - Browse repository at this point
Copy the full SHA 8f1de10View commit details -
rename a confusingly-named helper function
http://jneen.net/ committedDec 9, 2019 Configuration menu - View commit details
-
Copy full SHA for 8eb5f9e - Browse repository at this point
Copy the full SHA 8eb5f9eView commit details -
properly set up the webpack import resolver for eslint
http://jneen.net/ committedDec 9, 2019 Configuration menu - View commit details
-
Copy full SHA for b5a609a - Browse repository at this point
Copy the full SHA b5a609aView commit details -
suppress the lgtm bot warning for document.write
http://jneen.net/ committedDec 9, 2019 Configuration menu - View commit details
-
Copy full SHA for 62b898a - Browse repository at this point
Copy the full SHA 62b898aView commit details -
fix and simplify the logic of details-polyfill-detect
http://jneen.net/ committedDec 9, 2019 Configuration menu - View commit details
-
Copy full SHA for ef0f025 - Browse repository at this point
Copy the full SHA ef0f025View commit details -
use <button>s for the add / remove buttons
http://jneen.net/ committedDec 9, 2019 Configuration menu - View commit details
-
Copy full SHA for 76e9d42 - Browse repository at this point
Copy the full SHA 76e9d42View commit details