Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SNS for international phone numbers #2195

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Conversation

sastels
Copy link
Collaborator

@sastels sastels commented Jun 19, 2024

Summary | Résumé

Pinpoint is having a problem sending to international phone numbers. This PR sends them with SNS instead.

Related Issues | Cartes liées

Test instructions | Instructions pour tester la modification

Send a SMS to the UK BT Text number +4408456021111
SNS should be used to send (in the logs "AWS SNS request finished in...")

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

@sastels sastels marked this pull request as ready for review June 19, 2024 18:50
@sastels sastels requested review from a team, jimleroyer and ben851 and removed request for a team June 19, 2024 18:55
Co-authored-by: Ben Larabie <benlarabie@gmail.com>
@sastels sastels requested a review from ben851 June 19, 2024 19:28
Copy link
Contributor

@ben851 ben851 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sastels sastels merged commit e6221d5 into main Jun 19, 2024
4 checks passed
@sastels sastels deleted the all-international-through-sns branch June 19, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants