Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fail detection to k8s rollout #148

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Adding fail detection to k8s rollout #148

merged 1 commit into from
Mar 25, 2024

Conversation

ben851
Copy link
Contributor

@ben851 ben851 commented Mar 21, 2024

Summary | Résumé

Adding fault detection to k8s rollout call in docker workflow.

Related Issues | Cartes liées

Test instructions | Instructions pour tester la modification

Ensure that k8s workflow is triggered properly

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

Copy link

A review app will be deployed. Get the URL by going to https://cds-snc.github.io/notification-documentation/

Copy link

Review Apps

URLS

Last updated at

Thu Mar 21 2024 19:58:50 GMT+0000 (Coordinated Universal Time)

Copy link

@P0NDER0SA P0NDER0SA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean enough. Looks ok

@ben851 ben851 merged commit 910f947 into main Mar 25, 2024
1 check passed
@ben851 ben851 deleted the k8s-rollout-fail branch March 25, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants