Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Removed ipv4 cron job and restart service account #2305

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

jimleroyer
Copy link
Member

What happens when your PR merges?

  • Prefix the title of your PR:
    • fix: - tag main as a new patch release
    • feat: - tag main as a new minor release
    • BREAKING CHANGE: - tag main as a new major release
    • [MANIFEST] - tag main as a new patch release and deploy to production
    • chore: - use for changes to non-app code (ex: GitHub actions)
  • Alternatively, change the VERSION file - this will not create a new tag, but rather will release the tag in VERSION to production.

What are you changing?

  • Releasing a new version of Notify
  • Changing kubernetes configuration

Provide some background on the changes

Removed the ipv4-geolocate-service cronjob that performed an automated rollout every Wednesday at 11 am EST. These will now be handled by the github actions of ipv4-geolocate-service directly when an update occurs.

If you are releasing a new version of Notify, what components are you updating

  • API
  • Admin
  • Documentation
  • Document download API

Checklist if releasing new version:

Checklist if making changes to Kubernetes:

  • I know how to get kubectl credentials in case it catches on fire

After merging this PR

  • I have verified that the tests / deployment actions succeeded
  • I have verified that any affected pods were restarted successfully
  • I have verified that I can still log into Notify production
  • I have verified that the smoke tests still pass on production
  • I have communicated the release in the #notify Slack channel.

@jimleroyer jimleroyer changed the title feat: Removed ipv4 restart service account feat: Removed ipv4 cron job and restart service account Jan 16, 2024
Copy link
Collaborator

@ben851 ben851 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jimleroyer
Copy link
Member Author

We manually deleted the resources affected by this PR via clickops in dev, staging and production. Merging now to prevent further creation of these in the future.

@jimleroyer jimleroyer merged commit de270c0 into main Jan 18, 2024
2 checks passed
@jimleroyer jimleroyer deleted the destroy/remove-ipv4-cronjob branch January 18, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants