Remove queuing for StatsD client (#66)

notifications_utils/clients/statsd/statsd_client.py

@@ -1,6 +1,5 @@
 import random
 import time
-from collections import deque
 from socket import AF_INET, SOCK_DGRAM, gethostbyname, socket
 
 import cachetools.func
@@ -19,7 +18,6 @@ def __init__(self, host, port, prefix):
         self._port = port
         self._prefix = prefix
         self._sock = socket(AF_INET, SOCK_DGRAM)
-        self._queue = deque()
 
     def _resolve(self, addr):
         return gethostbyname(addr)
@@ -35,16 +33,13 @@ def _cached_host(self):
             return None
 
     def _send(self, data):
-        self._queue.append(data)
         try:
             host = self._cached_host()
             # If we can't resolve DNS, then host is `None`
-            # Don't send to statsd, data will be sent later
+            # Don't send to statsd
             if host is None:
                 return
-
-            for elem in self._queue:
-                self._sock.sendto(elem.encode('ascii'), (host, self._port))
+            self._sock.sendto(data.encode('ascii'), (host, self._port))
         except Exception as e:
             current_app.logger.warning('Error sending statsd metric: {}'.format(str(e)))
             pass

notifications_utils/version.py

@@ -1,2 +1,2 @@
-__version__ = '43.1.0'
+__version__ = '43.1.1'
 # GDS version '34.0.1'

tests/test_statsd_client.py

@@ -116,21 +116,6 @@ def test_should_not_attempt_to_send_if_cache_contains_none(app, mocker):
     assert mock_sock.called is False
 
 
-def test_records_points_when_cache_contains_none(app, mocker):
-    stats_client = NotifyStatsClient('localhost', 8125, '')
-    mock_sock = mocker.patch.object(stats_client, "_sock")
-    mock_cached_host = mocker.patch.object(stats_client, '_cached_host', side_effect=[None, '1.2.3.4'])
-
-    stats_client._send('data')
-    mock_cached_host.assert_called_once_with()
-    assert mock_sock.called is False
-    assert len(stats_client._queue) == 1
-
-    stats_client._send('foo')
-    assert mock_sock.called is False
-    assert len(stats_client._queue) == 2
-
-
 def test_should_manage_dns(app, mocker):
     stats_client = NotifyStatsClient('exporter.apps.internal', 8125, '')