Latest round for the waffle github action #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sastels
approved these changes
Dec 23, 2021
| app-loc: '/doc-api-env/Lib/site-packages' | ||
| app-libs: '/Projects/cds/notification-document-download-api' | ||
| flask-mod: 'application' | ||
| flask-prop: 'application' | ||
| base-url: 'https://api.document.staging.notification.cdssandbox.xyz' |
There was a problem hiding this comment.
should have this block in ```'s
| app-loc: '/doc-api-env/Lib/site-packages' | ||
| app-libs: '/Projects/cds/notification-document-download-api' |
There was a problem hiding this comment.
app-loc should be '/Projects/cds/notification-document-download-api' and app-libs '/doc-api-env/Lib/site-packages', right?
There was a problem hiding this comment.
Right, I changed that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Latest round for the waffle github action. Current action failed to load the entry point with the docker image configuration and missed required Flask dependency. There are a few minor changes all around as well.
Test instructions | Instructions pour tester la modification
I am basically testing the action right now through this PR.