feat: adding ability to get all keys matching a specific pattern. Added functions to construct the service and template keys #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed functions to construct the service and template keys
jimleroyer
requested changes
Jul 26, 2021
|
|
||
|
|
||
| def service_cache_key(service_id): | ||
| return f"service-{service_id}" |
tests/test_redis_client.py
Outdated
|
|
||
|
|
||
| def test_should_call_get_cache_keys_by_pattern_if_enabled(mocked_redis_client): | ||
| assert mocked_redis_client.get_cache_keys_by_pattern("test-key-*") == [b"test-1243", b"test-23423423"] |
There was a problem hiding this comment.
If the parameter is a regular expression, I would not expect these keys to get returned as they would not fix test-key-*. A proper regex for the expected keys would be test-[\d]+. My impression is that the parameter format correspond more to a glob than a regex.
There was a problem hiding this comment.
you're probably right. It turns our I do not need this function anyways to make it work. So I removed it
jimleroyer
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
To reduce duplication I added additional functions to generate the template and service key patterns.
Test instructions | Instructions pour tester la modification
Run unit tests !
Help requested | Aide requise
N/A
Reviewer checklist | Liste de vérification du réviseur
This is a suggested checklist of questions reviewers might ask during their
review | Voici une suggestion de liste de vérification comprenant des questions
que les réviseurs pourraient poser pendant leur examen :
langues officielles?
une baisse de la quantité de code couvert par les tests automatisés?
fonctionnalité existante?
que ça devrait être divisé en de plus petites demandes de tirage (« pull
requests ») afin de réduire le risque lié aux modifications?
modification de la politique de confidentialité?
préoccupations liées à la sécurité?
façon importante la performance?
risque d’utiliser des dépendances ajoutées?
setup, etc.) | Faudra-t-il mettre à jour la documentation à la suite de ce
changement (fichier README, etc.)?