Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add permission condition interpolation feature #1135

Merged
merged 1 commit into from
Oct 13, 2022
Merged

feat: add permission condition interpolation feature #1135

merged 1 commit into from
Oct 13, 2022

Conversation

craigzour
Copy link
Contributor

Summary | Résumé

  • Added permission condition interpolation feature
  • Added tests for new interpolation function

@craigzour craigzour self-assigned this Oct 13, 2022
@github-actions
Copy link
Contributor

Storybooks Link For Branch
https://cds-snc.github.io/platform-forms-client/refs/pull/1135/merge

@craigzour
Copy link
Contributor Author

@bryan-robitaille CI errors are linked to legacy code (UserRole). Would you like me to fix them as part of an initial clean-up?

bryan-robitaille
bryan-robitaille approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@bryan-robitaille bryan-robitaille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a single comment on how we can remove the import for {AnyObject} type.

lib/policyBuilder.ts Outdated Show resolved Hide resolved
@craigzour craigzour force-pushed the feature/permissions-interpolate-function branch from 7df0c41 to bf35da9 Compare October 13, 2022 16:22
@bryan-robitaille
Copy link
Contributor

We can clean them up as part of our test modifications as we wrap the CRUD functions with permissions.

@craigzour craigzour merged commit fb34186 into feature/permissions Oct 13, 2022
@craigzour craigzour deleted the feature/permissions-interpolate-function branch October 13, 2022 16:27
This was referenced Oct 13, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryan-robitaille bryan-robitaille bryan-robitaille approved these changes

Assignees

@craigzour craigzour

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@craigzour @bryan-robitaille