Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link editor #1195

Merged
merged 19 commits into from Nov 4, 2022
Merged

Update link editor #1195

merged 19 commits into from Nov 4, 2022

Conversation

dsamojlenko
Copy link
Member

@dsamojlenko dsamojlenko commented Nov 1, 2022

Summary | Résumé

Link editor improvements. Adds an Edit button per the Lexical Sandbox example. Also restructures the code a bit to be more like the example from the Sandbox.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

@dsamojlenko dsamojlenko marked this pull request as ready for review November 1, 2022 19:19
@timarney
Copy link
Member

timarney commented Nov 1, 2022

  1. Let's get this focus background fixed up

Screen Shot 2022-11-01 at 3 47 19 PM

  1. Thinking it would be nice if we could avoid the link in the popup from being a real link --- too easy to click out

  2. As discussed it would be nice to get link editor to close when you tab / esc out etc... but maybe that's in a followup PR

@timarney
Copy link
Member

timarney commented Nov 4, 2022

@dsamojlenko --- you should be able to merge this one

@dsamojlenko dsamojlenko merged commit abb7be0 into develop Nov 4, 2022
@dsamojlenko dsamojlenko deleted the feature/richTextEditor_link_plugin branch November 4, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants