New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport the preview and test features to original Form component #1240
Merged
dsamojlenko
merged 8 commits into
develop
from
feature/merge_preview_features_to_original_form_component
Nov 10, 2022
Merged
Backport the preview and test features to original Form component #1240
dsamojlenko
merged 8 commits into
develop
from
feature/merge_preview_features_to_original_form_component
Nov 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storybooks Link For Branch |
timarney
reviewed
Nov 9, 2022
timarney
reviewed
Nov 9, 2022
timarney
reviewed
Nov 9, 2022
bryan-robitaille
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
timarney
approved these changes
Nov 10, 2022
dsamojlenko
deleted the
feature/merge_preview_features_to_original_form_component
branch
November 10, 2022 14:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
This PR backports some customizations we had made to the Form component for use in the Preview and TestDataDelivery functions of the FormBuilder. We had been maintaining a separate copy of the Form component in order to test, but are now backporting those changes, and updating the references to it.
There are three new props on the Form component:
isPreview
(optional | boolean) indicates if this is a Preview and if so, disables the Submit buttonrenderSubmit
(optional | JSX.Element) if you need to customize around the Submit button (for example, to have a message appear next to it)onSuccess
(optional | function) on successful submit, fire a provided action, preventing a full redirect (for TestDataDelivery)Also added the Introduction and PrivacyPolicy RichText components to the form render as well.
Pull Request Checklist
Please complete the following items in the checklist before you request a review: