Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back the Save page #1283

Merged
merged 11 commits into from Nov 16, 2022
Merged

Bring back the Save page #1283

merged 11 commits into from Nov 16, 2022

Conversation

dsamojlenko
Copy link
Member

@dsamojlenko dsamojlenko commented Nov 16, 2022

Summary | Résumé

Brings back the Save page, and hides the Save button in the Header when logged out.

Pull Request Checklist

Please complete the following items in the checklist before you request a review:

  • Have you completely tested the functionality of change introduced in this PR? Is the PR solving the problem it's meant to solve within the scope of the related issue?
  • The PR does not introduce any new issues such as failed tests, console warnings or new bugs.
  • If this PR adds a package have you ensured its licensed correctly and does not add additional security issues?
  • Is the code clean, readable and maintainable? Is it easy to understand and comprehend.
  • Does your code have adequate comprehensible comments? Do new functions have docstrings?
  • Have you modified the change log and updated any relevant documentation?
  • Is there adequate test coverage? Both unit tests and end-to-end tests where applicable?
  • If your PR is touching any UI is it accessible? Have you tested it with a screen reader? Have you tested it with automated testing tools such as axe?

@github-actions
Copy link
Contributor

pcraig3
pcraig3 previously approved these changes Nov 16, 2022
Copy link
Contributor

@pcraig3 pcraig3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm Paul and I approve this Pull Request.

Copy link
Contributor

@pcraig3 pcraig3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved

@pcraig3 pcraig3 merged commit 1868b01 into develop Nov 16, 2022
@pcraig3 pcraig3 deleted the feature/hide_save_button_logged_out branch November 16, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants