Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert drag/drop sort to operate on groups instead #3513

Merged
merged 7 commits into from May 2, 2024

Conversation

dsamojlenko
Copy link
Member

@dsamojlenko dsamojlenko commented Apr 24, 2024

Summary | Résumé

Drag/Drop sorting for TreeView.
Old function was operating on TreeData and was overly complicated and not working correctly.
Converted to operating on Groups data which has proven easier/cleaner.

Drag/Drop test cases:

  • Drag/drop root level groups at root level
  • Cannot drag/drop root level groups to group level
  • Drag/drop items within a group
  • Select multiple items and drag/drop within a group
  • Drag/drop items across groups
  • Select multiple items in a group and drag/drop to another group
  • Select items in multiple groups and drag/drop to another group
  • Select items in multiple groups and drag/drop to different position in one of the selected groups
  • Cannot select an item and a group and drag/drop anywhere

Copy link
Contributor

@dsamojlenko dsamojlenko marked this pull request as draft April 24, 2024 20:48
@dsamojlenko dsamojlenko marked this pull request as ready for review May 2, 2024 15:27
timarney
timarney previously approved these changes May 2, 2024
@dsamojlenko dsamojlenko enabled auto-merge (squash) May 2, 2024 15:36
@dsamojlenko dsamojlenko merged commit f4a066e into feature/nextjs_app_router May 2, 2024
9 of 10 checks passed
@dsamojlenko dsamojlenko deleted the drag_drop_sorting branch May 2, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants