Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

Update to Apollo 2.5 #185

Merged
merged 1 commit into from
Mar 13, 2019
Merged

Update to Apollo 2.5 #185

merged 1 commit into from
Mar 13, 2019

Conversation

sleepycat
Copy link
Contributor

Apollo 2.5 has made state management a first class citizen by folding the
apollo-link-state package into ApolloClient.

This commit reworks our state management to use the new 2.5 syntax and
refactors some code and tests to get everything working smoothly.

Client side resolvers are finally being properly tested and imported
when the ApolloClient is created.

@sleepycat sleepycat requested a review from evadb March 12, 2019 19:20
@sastels sastels temporarily deployed to rac-prototype-pr-185 March 12, 2019 19:58 Inactive
Copy link

@evadb evadb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment shared with you via slack, otherwise LGTM 👍

Apollo 2.5 has made state management a first class citizen by folding the
apollo-link-state package into ApolloClient.

This commit reworks our state management to use the new 2.5 syntax and
refactors some code and tests to get everything working smoothly.

Client side resolvers are finally being properly tested and imported
when the ApolloClient is created.

The API URI from the client is just `/graphql`. Prefetching data from the API
during SSR requires a server side url. The default supplied in
createApolloClient was wrong (it made sense only for local dev), and the proper
handling of this required a minor change to the k8s config.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants