-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task tags filter for influx publisher #285
Conversation
added an option to configure influx publisher to specify which values to use as fields vs tags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yarolegovich. I think the PR adds more elegant implementation and I like the approach of the Metrics
interface. Approved!
Honestly, in terms of cardinality, always the efforts pointed to the build metrics, not thinking in task metrics. Thank you very much for the contribution. Once it is merged, I will add E2ETest.
Hi again. Apologies, but I had to fix one issue with the build in CI. The change is already in master. Do you mind updating your branch? Thanks |
Synced with upstream, thanks. Also realised we can live without a static method for key lookups eaf5c66 |
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
============================================
+ Coverage 52.08% 52.32% +0.23%
- Complexity 284 290 +6
============================================
Files 98 100 +2
Lines 1776 1787 +11
Branches 254 253 -1
============================================
+ Hits 925 935 +10
- Misses 773 774 +1
Partials 78 78
Continue to review full report at Codecov.
|
Extended InfluxDbPublisher config adding a task tags filter by analogy with build tags.