Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task tags filter for influx publisher #285

Merged
merged 4 commits into from
Apr 14, 2021
Merged

Task tags filter for influx publisher #285

merged 4 commits into from
Apr 14, 2021

Conversation

yarolegovich
Copy link
Contributor

Extended InfluxDbPublisher config adding a task tags filter by analogy with build tags.

added an option to configure influx publisher to specify which values to use as fields vs tags
Copy link
Owner

@cdsap cdsap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yarolegovich. I think the PR adds more elegant implementation and I like the approach of the Metrics interface. Approved!
Honestly, in terms of cardinality, always the efforts pointed to the build metrics, not thinking in task metrics. Thank you very much for the contribution. Once it is merged, I will add E2ETest.

@cdsap
Copy link
Owner

cdsap commented Apr 14, 2021

Hi again. Apologies, but I had to fix one issue with the build in CI. The change is already in master. Do you mind updating your branch?
(I tested already and looks good)

Thanks

@yarolegovich
Copy link
Contributor Author

Synced with upstream, thanks. Also realised we can live without a static method for key lookups eaf5c66

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #285 (eaf5c66) into master (acc5960) will increase coverage by 0.23%.
The diff coverage is 79.06%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #285      +/-   ##
============================================
+ Coverage     52.08%   52.32%   +0.23%     
- Complexity      284      290       +6     
============================================
  Files            98      100       +2     
  Lines          1776     1787      +11     
  Branches        254      253       -1     
============================================
+ Hits            925      935      +10     
- Misses          773      774       +1     
  Partials         78       78              
Impacted Files Coverage Δ Complexity Δ
...c/main/kotlin/com/cdsap/talaiot/metrics/Metrics.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../cdsap/talaiot/metrics/DefaultBuildDataProvider.kt 64.70% <62.22%> (ø) 0.00 <0.00> (ø)
...n/kotlin/com/cdsap/talaiot/metrics/BuildMetrics.kt 100.00% <100.00%> (ø) 4.00 <2.00> (+2.00)
...m/cdsap/talaiot/metrics/DefaultTaskDataProvider.kt 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
...in/kotlin/com/cdsap/talaiot/metrics/TaskMetrics.kt 100.00% <100.00%> (ø) 3.00 <3.00> (?)
...ap/talaiot/publisher/influxdb/InfluxDbPublisher.kt 74.41% <100.00%> (+0.92%) 8.00 <1.00> (-1.00) ⬆️
...blisher/influxdb/InfluxDbPublisherConfiguration.kt 86.95% <100.00%> (+0.59%) 11.00 <1.00> (+2.00)
...sap/talaiot/publisher/influxdb/TagFieldProvider.kt 100.00% <100.00%> (ø) 12.00 <7.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acc5960...eaf5c66. Read the comment docs.

@cdsap cdsap merged commit bfe63af into cdsap:master Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants