Skip to content

Commit

Permalink
fix settle dates tests
Browse files Browse the repository at this point in the history
  • Loading branch information
cdump committed Jan 29, 2022
1 parent 42ec294 commit aea0797
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions investments/report_parsers/ib.py
Original file line number Diff line number Diff line change
Expand Up @@ -281,13 +281,13 @@ def _parse_trades(self, f: Dict[str, str]):

dt = _parse_datetime(f['Date/Time'])

settle_date_item = self._settle_dates.get(ticker.symbol, dt)
assert settle_date_item is not None
settle_date = self._settle_dates.get_date(ticker.symbol, dt)
assert settle_date is not None

self._trades.append(Trade(
ticker=ticker,
trade_date=dt,
settle_date=settle_date_item.settle_date,
settle_date=settle_date,
quantity=_parse_trade_quantity(f['Quantity']) * quantity_multiplier,
price=Money(f['T. Price'], currency),
fee=Money(f['Comm/Fee'], currency),
Expand Down
10 changes: 5 additions & 5 deletions tests/report_parsers/ib_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -233,11 +233,11 @@ def test_parse_trades_with_thousands_separator():
Trades,SubTotal,,Stocks,USD,NOK,,"2,299.81",,,-8770.9,-14.1,8785,0,79.5,"""

lines = lines.split('\n')
p._settle_dates = {
('NOK', _parse_datetime('2020-04-03, 09:48:58')): _parse_date('2020-02-04'),
('NOK', _parse_datetime('2020-04-06, 11:43:36')): _parse_date('2020-02-12'),
('NOK', _parse_datetime('2020-04-06, 11:44:50')): _parse_date('2020-02-12'),
}

p._settle_dates.put('NOK', _parse_datetime('2020-04-03, 09:48:58'), _parse_date('2020-02-04'), 'a')
p._settle_dates.put('NOK', _parse_datetime('2020-04-06, 11:43:36'), _parse_date('2020-02-12'), 'b')
p._settle_dates.put('NOK', _parse_datetime('2020-04-06, 11:44:50'), _parse_date('2020-02-12'), 'c')

p._real_parse_activity_csv(csv.reader(lines, delimiter=','), {
'Financial Instrument Information': p._parse_instrument_information,
'Trades': p._parse_trades,
Expand Down

0 comments on commit aea0797

Please sign in to comment.