Added the possibility of building and running the project on Mac (without bluetooth) #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecting to the Radiacode via USB
|
Doesn't break on my Ubuntu machine. |
cdump
requested changes
May 9, 2024
|
and codestyle errors from tests: https://github.com/cdump/radiacode/actions/runs/8958200767/job/24765854405?pr=32 |
|
Please fix |
|
I somehow missed it, fixed and pushed. |
|
Still have code-format ruff issues - you can run tests localy: https://github.com/cdump/radiacode/blob/master/.github/workflows/tests.yml#L26 |
|
Last one should be the good one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to bluepy not working on Mac, it's not possible to install and run the project on Mac devices as it is. I modified the project so that bluepy is excluded from the build if the platform is a Mac. I've also made some changes to basic.py to allow the main example to run on Mac as well.