Update jsonwebtoken to latest version #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update key algorithm handling when initializing key data
|
Hi, thanks for this PR! |
|
Hey, just noticed I missed one test in tonic. I think it's okay to not regenerate test tokens. The changes are required only because aud is validated against if it's present in the token in newer versions of jsonwebtoken. |
|
already added the tokens ;), this is also to test more more precisely with and without auditions. |
|
Seems tests are still passing without any changes on my side :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates jsonwebtoken to latest version and also updates key algorithm handling when initializing key data.
Should close #25.