Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCC-specific __attribute__((packed)) not supported in MSVC, causing MSVC builds to fail #27

Closed
alberthdev opened this issue Feb 18, 2016 · 1 comment
Closed

GCC-specific __attribute__((packed)) not supported in MSVC, causing MSVC builds to fail #27

alberthdev opened this issue Feb 18, 2016 · 1 comment
Assignees
@alberthdev
Milestone
v1.0

Comments

@alberthdev
Copy link
Collaborator

Currently, new GCC-specific attributes have been added, which have recently caused MSVC builds to fail: https://ci.appveyor.com/project/alberthdev/cemu

A suggested MSVC-compatible alternative would be to create a special define to wrap the structs with, with similar functionality on both GCC and MSVC:
http://stackoverflow.com/a/9504047/1094484
alberthdev added a commit that referenced this issue Feb 18, 2016
@alberthdev
Fix issue #27 via wrapping compiler specific functions with macros
2d67cae
@alberthdev alberthdev self-assigned this Feb 18, 2016
@alberthdev
Copy link
Collaborator Author

Closing - this has been fixed in commit 2d67cae, and both Travis-CI and AppVeyor are successfully building. If there are any issues that crop up from this commit, feel free to re-open this issue!

@adriweb adriweb modified the milestone: v1.0 target Mar 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alberthdev alberthdev

Labels
None yet
Milestone
v1.0
Development

No branches or pull requests
2 participants
@adriweb @alberthdev