"reliable" MQTT port (paho) #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st-reliable-mqtt # Conflicts: # cerk_port_mqtt/Cargo.toml # cerk_port_mqtt/README.md # cerk_port_mqtt/src/lib.rs # cerk_runtime_threading/Cargo.toml
linuxbasic
force-pushed
the
feat/test-reliable-mqtt
branch
from
d209c56
to
0bf8bdc
Compare
Lazzaretti
requested changes
Dec 12, 2020
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "cerk_port_mqtt" | |||
| version = "0.2.6" | |||
| version = "0.3.0" | |||
There was a problem hiding this comment.
this will be done in a separate release process
| paho-mqtt = { version = "0.6.0", features = ["bundled", "build_bindgen"], default-features = false } | ||
| paho-mqtt = { version="0.8.0", features=["bundled", "build_bindgen"], default-features = false} | ||
| anyhow = "1.0" | ||
| async-std = "1.7.0" |
There was a problem hiding this comment.
Suggested change
| async-std = "1.7.0" | |
| async-std = "1.7" |
| @@ -20,4 +20,6 @@ env_logger = "0.7.1" | |||
| cerk = { version = "0.2", path = "../cerk" } | |||
| cloudevents-sdk = "0.3.0" | |||
There was a problem hiding this comment.
Suggested change
| cloudevents-sdk = "0.3.0" | |
| cloudevents-sdk = "0.3" |
| match serde_json::from_str::<Event>(&payload_str) { | ||
| Ok(cloud_event) => { | ||
| debug!("{} deserialized event successfully", id); | ||
| // todo add delivery attempt to routing id |
| let routing_args = CloudEventRoutingArgs { | ||
| delivery_guarantee: match connection.subscribe_qos { | ||
| 0 => DeliveryGuarantee::BestEffort, | ||
| _ => panic!("The MQTT Port Currently only supports QoS 0 (see https://github.com/ce-rust/cerk/issues/71)"), |
Comment on lines
-234
to
-236
| #[cfg(test)] | ||
| mod tests { | ||
| use super::*; |
There was a problem hiding this comment.
Why have you removed all tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cerk_port_mqttIncomingCloudEventProcessedandOutgoingCloudEventProcessed)subscribe_topicconfigurablesubscribe_qosonly supports value0(see MQTT Port: Support for QoS 1/2 #71)persistencenot configurable anymore (always no persistence)cerk_runtime_threading