Skip to content

Commit

Permalink
Hold error count raise when report is held
Browse files Browse the repository at this point in the history
Update held report mechanism to also hold error count to raise when
activated. With this change no more error is rendered when a requirement
cannot be loaded but an alternative one can.

Fixes #510
  • Loading branch information
xdelaruelle committed Sep 10, 2023
1 parent 4457c15 commit cb41b45
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
2 changes: 2 additions & 0 deletions NEWS.rst
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ Modules 5.4.0 (not yet released)
understand the chronology of actions and from where an error occurs.
* Do not report requirement load error when an an alternative requirement
module is found and loaded afterward. (fix issue #509)
* Do not render an error exit code on multi-module option requirement when
one module option fails to load but another does. (fix issue #510)


.. _5.3 release notes:
Expand Down
8 changes: 7 additions & 1 deletion tcl/envmngt.tcl.in
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,13 @@
##########################################################################

proc raiseErrorCount {} {
setState error_count [expr {[getState error_count] + 1}]
# hold error count raise
if {[depthState reportholdid] > 0} {
lappend ::g_holdReport([currentState reportholdid]) [list\
raiseErrorCount]
} else {
setState error_count [expr {[getState error_count] + 1}]
}
}

proc renderFalse {} {
Expand Down

0 comments on commit cb41b45

Please sign in to comment.