Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for NO_COLOR #310

Closed
cmarqu opened this issue Jan 30, 2020 · 1 comment
Closed

Support for NO_COLOR #310

cmarqu opened this issue Jan 30, 2020 · 1 comment
Milestone

Comments

@cmarqu
Copy link
Contributor

cmarqu commented Jan 30, 2020

There is a "competing" initiative to the CLICOLOR* variables implemented in #279:
https://no-color.org/, suggesting the variable NO_COLOR. Maybe modules should honor it too.

@xdelaruelle
Copy link
Member

It reminds me of how standards proliferate. Joke aside, there is no problem to also honor this NO_COLOR variable.

Would you try a pull request for that? Work should be quite straightforward, based on code done for CLICOLOR (+manpage update, + few tests cases in testsuite/modules.00-init/140-color.exp)

@xdelaruelle xdelaruelle added this to the 4.5 milestone Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants