Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags set through prereq not updated on loaded secondary requirement #459

Closed
xdelaruelle opened this issue May 28, 2022 · 0 comments
Closed
Labels
Milestone

Comments

@xdelaruelle
Copy link
Member

On version 5.1.0, when setting tags through a prereq command defining a list of requirements (two or more), the tags are not set on already loaded or loading alternative requirements (other than the first one).

Issue can be demonstrated when loading the additional requirement when dependent module is already loaded. In this situation, the reload of the dependent module should update the tags set on the loading requirement:

$ ml show mod
-------------------------------------------------------------------
/path/to/modulefiles/mod/1.0:

prereq          --tag=foo foo/1.0 bar/1.0
-------------------------------------------------------------------
$ ml mod
Loading mod/1.0
  Loading requirement: foo/1.0
$ ml bar/1.0
Loading bar/1.0
  Unloading dependent: mod/1.0
  Reloading dependent: mod/1.0
$ ml
Currently Loaded Modulefiles:
 1) foo/1.0 <foo>   2) bar/1.0   3) mod/1.0  

Key:
auto-loaded  <module-tag>  

When more than one requirement are already loaded then we try to load the dependent module, this module only updates the tags on the first dependent module in list:

$ ml purge
$ ml foo bar
$ ml
Currently Loaded Modulefiles:
 1) foo/1.0   2) bar/1.0  
$ ml mod
$ ml
Currently Loaded Modulefiles:
 1) foo/1.0 <foo>   2) bar/1.0   3) mod/1.0  

Key:
<module-tag>
@xdelaruelle xdelaruelle added this to the 5.1.1 milestone May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant