Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODULEPATH aware module-tag use #485

Closed
wenzler opened this issue Feb 23, 2023 · 4 comments
Closed

MODULEPATH aware module-tag use #485

wenzler opened this issue Feb 23, 2023 · 4 comments
Milestone

Comments

@wenzler
Copy link

wenzler commented Feb 23, 2023

Is your feature request related to a problem? Please describe.

No.
But module-tag requires not a file name but module name/alias as parameter.
Thus it is not aware of the same module name being available in a different MODULEPATH repos.

Describe the solution you'd like

Allow definition of the actual filename (as in module display)
module-tag "Patched" /root/common/modules/git/1.0

Would also be good to have the tags displayed in the module display output ,btw :)

Describe alternatives you've considered

Joining the space marines to seek out new life and new civilizations

Additional context

Tested in 5.2.0

Thanks!

@xdelaruelle
Copy link
Member

xdelaruelle commented Mar 2, 2023 via email

@xdelaruelle
Copy link
Member

Comment about performance issue has been removed so I assume this issue has been solved on your side. If you still have an issue, please open a separate ticket to distinguish from this feature request.

script/mb utility from this git repository helps to know the performance one can expect from various sub-commands.

@wenzler
Copy link
Author

wenzler commented Apr 14, 2023

Hey, sorry for late response
performance only suffers with thousands of different tags
Had added one module-tag line per module with identical tags first ;)

Would still be nice to have the module-tag accept MODULEPATH specific arguments like stated above

Cheers

@xdelaruelle xdelaruelle added this to the 5.4.0 milestone May 25, 2023
@xdelaruelle
Copy link
Member

Ability to specify modules with their full path file name on module-tag, module-hide and module-forbid has been developed. It will be part of the next feature release (5.4) that I plan to publish before the end of this year. Code will be integrated to main git branch once 5.3.1 bugfix release will be published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants