Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Shine event system to simplify shine event handling #54

Closed
degremont opened this issue Feb 26, 2010 · 3 comments
Closed

Update Shine event system to simplify shine event handling #54

degremont opened this issue Feb 26, 2010 · 3 comments
Assignees
Milestone

Comments

@degremont
Copy link
Collaborator

The current event handling system manages event as a simple name, like ev_starttarget_done, ... Due to this, each Shine EventHandler must declare a lot of different callback method even if in most cases the process is the same for each.

This ticket groups all effort to rewrite this part of code to simplify this to a unique or very few callbacks.

Reported by: degremont

@degremont
Copy link
Collaborator Author

        owner
          changed from st-cea to ad-cea
        
        status
            changed from new to accepted

Commit SVN commit r237 and SVN commit r238 simplify code before refactoring code.

Original comment by: degremont

@degremont
Copy link
Collaborator Author

Implemented in SVN commit r370.

Original comment by: degremont

@degremont
Copy link
Collaborator Author

        status
            changed from accepted to closed
        
        resolution
            set to fixed

Finalize with SVN commit r372.
This closes this ticket.

Original comment by: degremont

@degremont degremont added this to the 0.911 milestone May 24, 2017
@degremont degremont self-assigned this May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant